Repository navigation
fix(tools): publish NID database cache after download completes - #1328
Merged
adriadam10 merged 1 commit intoOct 10, 2026
Merged
Conversation
9 tasks done
darhebkf
force-pushed
the
codex/fix-nid-cache-download
branch
from
October 9, 2026 12:42
db8f2d4 to
46d7b30
Compare
darhebkf
marked this pull request as ready for review
October 9, 2026 13:56
adriadam10
force-pushed
the
codex/fix-nid-cache-download
branch
from
October 9, 2026 23:11
46d7b30 to
d440111
Compare
Collaborator
|
Checked: the temp-file + |
SleglJan
pushed a commit
to SleglJan/AnyPS5
that referenced
this pull request
Oct 10, 2026
…download fix(tools): publish NID database cache after download completes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
An interrupted download leaves a partial NID database that subsequent runs reuse. Download into a closed temporary file in the cache directory, publish it only after success, and clean up on failure. Register the four failure, retry and successful-cache regressions with CTest.
Tested
Rebased onto main
d70b8998. macOS 15.7.3, Apple Silicon, AppleClang 17, Python 3.14.6. nid_database_cache passed through CTest, covering four regressions. The new group took 0.10 s locally.The shared upstream C++ relinker sources were built in Release during this review; subsequent tool-only branches ran their affected CTest groups. Conventions and whitespace checks pass for each branch. Full Linux/Windows runtime validation requires a maintainer-dispatched Build run; no title or homebrew was executed.
Checklist
main; no other open PR implements the same fix.