Skip to content

fix(tools): publish NID database cache after download completes - #1328

Merged
adriadam10 merged 1 commit into
boykopovar:mainfrom
darhebkf:codex/fix-nid-cache-download
Oct 10, 2026
Merged

adriadam10 merged 1 commit into
boykopovar:mainfrom
darhebkf:codex/fix-nid-cache-download

Conversation

@darhebkf

@darhebkf darhebkf commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

What

An interrupted download leaves a partial NID database that subsequent runs reuse. Download into a closed temporary file in the cache directory, publish it only after success, and clean up on failure. Register the four failure, retry and successful-cache regressions with CTest.

Tested

Rebased onto main d70b8998. macOS 15.7.3, Apple Silicon, AppleClang 17, Python 3.14.6. nid_database_cache passed through CTest, covering four regressions. The new group took 0.10 s locally.

The shared upstream C++ relinker sources were built in Release during this review; subsequent tool-only branches ran their affected CTest groups. Conventions and whitespace checks pass for each branch. Full Linux/Windows runtime validation requires a maintainer-dispatched Build run; no title or homebrew was executed.

Checklist

  • Based on current main; no other open PR implements the same fix.
  • One topic per PR; this remains the same fix with its regression tests.
  • No source comments added; comment text in test fixtures is string data.
  • Unimplemented paths throw; no runtime exports or silent stubs added.
  • No notes, investigation files or images added to the repository.
  • No new third-party code.
  • Generic behaviour, not specific to one title.
  • New test groups finish well below 30 s locally; CI-runner timings remain unverified.
  • Depends on: none.
  • AI-assisted: yes.

@darhebkf
darhebkf force-pushed the codex/fix-nid-cache-download branch from db8f2d4 to 46d7b30 Compare October 9, 2026 12:42
@darhebkf
darhebkf marked this pull request as ready for review October 9, 2026 13:56
@github-actions github-actions Bot added the needs rebase Conflicts with main, rebase needed label Oct 9, 2026
@adriadam10
adriadam10 force-pushed the codex/fix-nid-cache-download branch from 46d7b30 to d440111 Compare October 9, 2026 23:11
@adriadam10

Copy link
Copy Markdown
Collaborator

Checked: the temp-file + replace flow leaves no partial cache on failure, the four regressions are registered in ctest, and nid_database_cache fails without the nid_names.py change. Full build + ctest green after the rebase (555/555).
Rebased onto main (test-list adjacency in CMakeLists.txt with pr_overlap_exports); merging once CI is green.

@github-actions github-actions Bot removed the needs rebase Conflicts with main, rebase needed label Oct 9, 2026
@adriadam10
adriadam10 merged commit dcfd4f6 into boykopovar:main Oct 10, 2026
7 checks passed
SleglJan pushed a commit to SleglJan/AnyPS5 that referenced this pull request Oct 10, 2026
…download

fix(tools): publish NID database cache after download completes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants