Repository navigation
test(tools): add test coverage for nid_names - #1662
Closed
Amirtheshwaran wants to merge 1 commit into
Closed
Amirtheshwaran wants to merge 1 commit into
Amirtheshwaran wants to merge 1 commit into
Conversation
This was referenced Oct 8, 2026
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add unit test coverage for
tools/nid_names.pyand register the test suite inCMakeLists.txt.tools/tests/test_nid_names.pycovering:compute_nid: symbol hashing across known PS5 vectors, output length (11), and charset validation.load_db: CSV database parsing, empty/short line handling, and fallback download execution.collect_unknowns: discovery ofAPS5_EXPORTunknown aliases across PRX sources.collect_real_names: discovery ofAPS5_VABIimplementations and_nid_postfixstripping.main: CLI handling acrossrename-ready(exit 0),already-implemented(exit 0),MISMATCH(exit 1), and--jsonserialization.main(argv=None)intools/nid_names.pyto receive customargvfor CLI testability.nid_namesin rootCMakeLists.txtunderBUILD_TESTING(touches the same test registration block as test(tools): add test coverage for check_test_registration #1623).Tested
Windows 11, Python 3.11:
python -m unittest discover -s tools/tests -v: 23 tests pass in 1.2s (including all 9NidNamesTeststest cases).python tools/check_conventions.py --base origin/main: passed (All conventions checks passed.).Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt.mdfiles or images added to the repository (attach them to this PR)