Skip to content

fix(types): allow omitted defaulted queries #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bytaesu merged 6 commits into from
Sep 5, 2026
Merged

fix(types): allow omitted defaulted queries #135

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
538089f
fix(types): allow omitted defaulted queries
bytaesu Sep 4, 2026
db7998a
Merge branch 'main' into 2026-09-05/fix/defaulted-query-options
bytaesu Sep 4, 2026
5e1d36f
fix(fetch): preserve omitted headers for validation
bytaesu Sep 4, 2026
c5ee174
fix(fetch): preserve explicit empty headers
bytaesu Sep 5, 2026
eaf0ac4
fix(fetch): merge default headers after validation
bytaesu Sep 5, 2026
3884af4
fix(fetch): preserve existing header validation semantics
bytaesu Sep 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/better-fetch/src/create-fetch/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ export type InferHeaders<H> = H extends StandardSchemaV1
: Record<string, string>;

export type IsFieldOptional<T> = T extends StandardSchemaV1
? undefined extends T
? undefined extends StandardSchemaV1.InferInput<T>
Comment thread
bytaesu marked this conversation as resolved.
? true
: false
: true;
Expand Down
22 changes: 22 additions & 0 deletions packages/better-fetch/src/test/create.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,28 @@ describe("create-fetch-runtime-test", () => {
});
});

it("applies a default query when options are omitted", async () => {
let requestQuery: unknown;
const fetch = createFetch({
baseURL: "https://example.com",
schema: createSchema({
"/movies": {
query: z
.object({ include: z.array(z.string()) })
.default({ include: ["recommendations"] }),
},
}),
customFetchImpl: async () => new Response(),
onRequest(context) {
requestQuery = context.query;
},
});

await fetch("/movies");

expect(requestQuery).toEqual({ include: ["recommendations"] });
});

it("should validate response and return data if validation passes", async () => {
const res = await $fetch("/echo", {
output: z.object({
Expand Down