Skip to content

fix(types): allow omitted defaulted queries - #135

Merged
bytaesu merged 6 commits into
mainfrom
2026-09-05/fix/defaulted-query-options
Sep 5, 2026
Merged

bytaesu merged 6 commits into
mainfrom
2026-09-05/fix/defaulted-query-options

Conversation

@bytaesu

@bytaesu bytaesu commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

closes #15

@bytaesu
bytaesu marked this pull request as ready for review September 4, 2026 21:54
@greptile-apps

greptile-apps Bot commented Sep 4, 2026 •

Copy link
Copy Markdown

Greptile Summary

This PR corrects schema optionality inference so query options may be omitted when the schema supplies a default.

  • Checks the inferred schema input for undefined rather than checking the schema object itself.
  • Adds runtime coverage confirming that an omitted query receives its schema-defined default.

Confidence Score: 5/5

The PR appears safe to merge, with no outstanding or newly introduced issues identified.

No changes were made after the previous review, and all three previous findings were manually resolved without explanatory replies.

Reviews (6): Last reviewed commit: "fix(fetch): preserve existing header val..." | Re-trigger Greptile

Comment thread packages/better-fetch/src/create-fetch/types.ts
Comment thread packages/better-fetch/src/create-fetch/index.ts Outdated
Comment thread packages/better-fetch/src/create-fetch/index.ts Outdated
@bytaesu

bytaesu commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator Author

@greptileai review

@bytaesu
bytaesu merged commit 2d16606 into main Sep 5, 2026
2 checks passed
@bytaesu bytaesu mentioned this pull request Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

query is required even when a default is provided

1 participant