Add fetch_for_asis setting to FetchArt plugin#6815
Open
overhacked wants to merge 3 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6815 +/- ##
=======================================
Coverage 74.94% 74.94%
=======================================
Files 163 163
Lines 21019 21022 +3
Branches 3310 3310
=======================================
+ Hits 15752 15755 +3
Misses 4513 4513
Partials 754 754
🚀 New features to boost your workflow:
|
snejus
requested changes
Jul 3, 2026
overhacked
force-pushed
the
overhacked/fetchart_asis
branch
4 times, most recently
from
22d3901 to
3b66c19
Compare
3 tasks
Member
|
You just need to rebase now and to resolve conflicts. |
Enable fetching art for imports even when as-is is selected as the metadata source. Allows for the case when files with good metadata but without album art are being imported (e.g. digital download store). Signed-off-by: Ross Williams <ross@ross-williams.net>
Signed-off-by: Ross Williams <ross@ross-williams.net>
Test whether fetchart is run during the import phase and, specifically, whether the `fetch_for_asis` setting is honored. Mock boundary is between `FetchArtPlugin` and `ArtSource`, an already-existing internal API boundary.
overhacked
force-pushed
the
overhacked/fetchart_asis
branch
from
3b66c19 to
6afc0f2
Compare
Author
|
@snejus rebased and ready! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
fetch_for_asissetting to FetchArt pluginDescription
Enable fetching art for imports even when as-is is selected as the metadata source. Allows for the case when files with good metadata but without album art are being imported (e.g. digital download store).
To Do