Embedded art extraction for fetchart plugin#1
Draft
overhacked wants to merge 9 commits into
Draft
Conversation
Enable fetching art for imports even when as-is is selected as the metadata source. Allows for the case when files with good metadata but without album art are being imported (e.g. digital download store). Signed-off-by: Ross Williams <ross@ross-williams.net>
Signed-off-by: Ross Williams <ross@ross-williams.net>
Test whether fetchart is run during the import phase and, specifically, whether the `fetch_for_asis` setting is honored. Signed-off-by: Ross Williams <ross@ross-williams.net>
Signed-off-by: Ross Williams <ross@ross-williams.net>
Signed-off-by: Ross Williams <ross@ross-williams.net>
Move mocks down the call tree so that the mock boundary is between `FetchArtPlugin` and `ArtSource`, an already-existing internal API boundary, instead of testing `FetchArtPlugin`'s implementation of selecting local versus remote sources.
Add `embedded` source to extract embedded art from files. Add `skip_embedded` option to detect embedded art and skip fetching from other sources (if extracting isn't the desired end state). If `skip_embedded=yes`, then files with embedded art are considered "done" and skipped by FetchArt. If the `embedded` source is enabled, then embedded artwork is always extracted. The two settings are independent of each other. Fix variable shadowing lint due to added import of `_utils.art`. Signed-off-by: Ross Williams <ross@ross-williams.net>
Add unit tests for Embedded source of FetchArt plugin. Add integration tests for FetchArt plugin's handling of files with embedded artwork. Signed-off-by: Ross Williams <ross@ross-williams.net>
Signed-off-by: Ross Williams <ross@ross-williams.net>
overhacked
force-pushed
the
overhacked/fetchart_asis
branch
from
3b66c19 to
6afc0f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
embeddedsource to extract embedded art from files. Addskip_embeddedoption to detect embedded art and skip fetching fromother sources (if extracting isn't the desired end state).
If
skip_embedded=yes, then files with embedded art are considered "done" andskipped by FetchArt. If the
embeddedsource is enabled, then embeddedartwork is always extracted. The two settings are independent of each
other.
Fixes beetbox#1130.
Stacked PR on beetbox#6815.
To Do