Skip to content

fix: ServerboundPlaceRecipe sends a RecipeDisplayId, not a resource location (1.21.2+) #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RobioEpo wants to merge 2 commits into from
Closed

fix: ServerboundPlaceRecipe sends a RecipeDisplayId, not a resource location (1.21.2+) #392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a40a024
fix: ServerboundPlaceRecipe uses RecipeDisplayId
RobioEpo Oct 14, 2026
41d26b3
fix: add RecipeDisplayId (VarInt newtype)
RobioEpo Oct 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions azalea-protocol/src/common/recipe.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,13 @@ use azalea_registry::{
identifier::Identifier,
};

/// A recipe display id (`RecipeDisplayId`), serialized as a VarInt.
///
/// Since 1.21.2 `ServerboundPlaceRecipe`'s second field is a `RecipeDisplayId`, not a
/// `ResourceLocation`/`Identifier` string.
#[derive(AzBuf, Clone, Copy, Debug, PartialEq, Eq, Hash)]
pub struct RecipeDisplayId(#[var] pub u32);

/// [`azalea_registry::builtin::RecipeDisplay`]
#[derive(AzBuf, Clone, Debug, PartialEq)]
pub enum RecipeDisplayData {
Expand Down
4 changes: 2 additions & 2 deletions azalea-protocol/src/packets/game/s_place_recipe.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
use azalea_buf::AzBuf;
use azalea_registry::identifier::Identifier;
use crate::common::recipe::RecipeDisplayId;
use azalea_protocol_macros::ServerboundGamePacket;

#[derive(AzBuf, Clone, Debug, PartialEq, ServerboundGamePacket)]
pub struct ServerboundPlaceRecipe {
#[var]
pub container_id: i32,
pub recipe: Identifier,
pub recipe: RecipeDisplayId,
pub shift_down: bool,
}