Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix:
ServerboundPlaceRecipesends a resource location where 1.21.2+ reads aRecipeDisplayIdWhat's wrong
ServerboundPlaceRecipeserializes its second field as anIdentifier(a resource-locationstring). Since 1.21.2 that field is a
RecipeDisplayId— a VarInt. A real craft thereforewrites ~23 bytes where the server reads 3, and the server disconnects the client:
Reproduced (azalea's own code)
Serializing the real packet with
AzBuf(ServerboundPlaceRecipe { container_id: 0, recipe: Identifier::new("minecraft:oak_planks"), shift_down: true }) gives, on currentmain/ddef371:VarInt(containerId=0)·VarInt(len=20)· the 20-byte string ·bool= 23 bytes.The 1.21.2+ server reads
VarInt(containerId) + VarInt(RecipeDisplayId) + bool= 3, so itreports 20 bytes extra — exactly the disconnect above.
Evidence
record ServerboundPlaceRecipePacket(int containerId, RecipeDisplayId recipe, boolean useMaxItems).RecipeDisplayId.getRecipe()… Replaced in 1.21.2 withgetRecipeId()/RecipeDisplayId".This affects
main(26.2) as well — the struct is unchanged.Fix
Add a
RecipeDisplayIdVarInt newtype and use it in the packet. With the fix the same serializationis 3 bytes (
[0, 20, 1]), matching the server, andazalea-protocolcompiles cleanly.(Sending a specific recipe then needs the display id from the recipe book — a separate concern from
this serialization fix.)