Move type, lint, and format checks into their own workflow - #2263
Merged
Merged
Conversation
5 tasks
kmcginnes
marked this pull request as ready for review
September 24, 2026 23:35
kmcginnes
added this pull request to stack #2265
September 24, 2026 23:36
kmcginnes
added a commit
that referenced
this pull request
Sep 24, 2026
## Description Moves the `checks` job (lockfile drift, types, lint, format) out of `unit.yml` into a new `checks.yml` workflow. The job itself is unchanged. This sets up the next PR, which skips unit tests and the Docker test build for docs-only changes. Formatting has to keep running on those PRs because it checks markdown, so it needs its own workflow without the path filter. ## Validation - `pnpm check:format` passes on the workflow files. - This PR's own run shows a separate Checks workflow alongside Unit Tests. ## Related Issues None. ### Check List - [x] I confirm that my contribution is made under the terms of the Apache 2.0 license. - [x] I have verified `pnpm checks` passes with no errors. - [x] I have verified `pnpm test` passes with no failures. - [ ] I have covered new added functionality with unit tests if necessary. - [ ] I have updated documentation if necessary.
kmcginnes
added a commit
that referenced
this pull request
Sep 24, 2026
## Description About a third of recent commits on `main` (20 of the last 60) touch only docs or agent files, and each of those PRs still waits through the unit test shards and the Docker test build. This adds `paths-ignore` to `unit.yml` (PR and push) and `test_build_docker.yml` (PR) for: - `docs/**` - `**/*.md` - `.agents/**` - `.claude/**` The Checks workflow from the previous PR has no filter, so markdown formatting still runs on every PR. Nothing under `packages/` or the Dockerfile reads a `.md` file, and `main` has no required status checks, so skipped workflows don't block merging. Dependency review also skips on docs-only PRs, which is fine since they can't change dependencies. Stacked on #2263. I'll rebase once it merges. ## Validation - Workflow YAML parses and passes `pnpm check:format`. - This PR changes workflow files, so its own run triggers every workflow. The real check is the next docs-only PR, which should show only Checks and CodeQL. ## Related Issues None. ### Check List - [x] I confirm that my contribution is made under the terms of the Apache 2.0 license. - [x] I have verified `pnpm checks` passes with no errors. - [x] I have verified `pnpm test` passes with no failures. - [ ] I have covered new added functionality with unit tests if necessary. - [ ] I have updated documentation if necessary.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moves the
checksjob (lockfile drift, types, lint, format) out ofunit.ymlinto a newchecks.ymlworkflow. The job itself is unchanged.This sets up the next PR, which skips unit tests and the Docker test build for docs-only changes. Formatting has to keep running on those PRs because it checks markdown, so it needs its own workflow without the path filter.
Validation
pnpm check:formatpasses on the workflow files.Related Issues
None.
Check List
pnpm checkspasses with no errors.pnpm testpasses with no failures.