Conversation
Restructure 4 workflow files into 3 with clearer responsibilities: - ci.yml: dependency review, static analysis, and tests as parallel jobs - docker.yml: build, test, scan, and conditionally push to ECR - security-audit.yml: daily Trivy scans built from source Key improvements: - Split checks and tests into parallel jobs with pnpm caching - Add sagemaker variant smoke test (server start on port 9250) - Upload coverage report as artifact - Build images from source in security audit instead of pulling from ECR - Scan both standard and sagemaker variants with os,library scope - Prevent in-progress cancellation on main for Docker pushes
Collaborator
Author
|
Closing this since the recent CI work covers it: #2263 moved type, lint, and format checks into their own workflow, #2259 sharded the unit tests, #2264 skips unit tests and the Docker test build for docs-only changes, and #2258 dropped coverage collection in CI. The SageMaker image build this still carries goes away with #1773. Anything left worth keeping can come back as a small PR against the current workflows. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Restructures 4 workflow files into 3 with clearer names and responsibilities:
ci.yml: Dependency review, static analysis, and tests as parallel jobs with pnpm cachingdocker.yml: Build, scan, smoke test, and conditionally push to ECR (single workflow replaces separate PR and publish workflows)security-audit.yml: Daily Trivy scans built from source against both image variantsKey improvements:
checks) and tests run in parallel for faster PR feedbackos,libraryscopeValidation
pnpm checkspass/statusresponds on port 9250Related Issues
Check List
pnpm checkspasses with no errors.pnpm testpasses with no failures.