Skip to content

[Fix] Add origins option to requestFileHandle #19960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akaashrp merged 3 commits into from
Jul 12, 2026
+2 −1
Merged

[Fix] Add origins option to requestFileHandle #19960

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
14d4a2c
Add `origins` option to `requestFileHandle`
tomayac Jul 6, 2026
98dd9e8
Add optional origins parameter to CrossOriginStorageRequestFileHandle…
tomayac Jul 6, 2026
cf20d67
Apply suggestion from @tomayac
tomayac Jul 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion web/src/artifact_cache.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ interface CrossOriginStorageHandle {

interface CrossOriginStorageRequestFileHandleOptions {
create?: boolean;
origins?: string[] | string | undefined;
}

interface CrossOriginStorageWritable {
Expand Down Expand Up @@ -188,7 +189,7 @@ class CrossOriginStorage {
if (!api) {
throw new Error("Cross-origin storage API unavailable.");
}
const handle = await api.requestFileHandle(hash, { create: true });
const handle = await api.requestFileHandle(hash, { create: true, origins: "*" });
Comment thread
tomayac marked this conversation as resolved.
Outdated
Comment thread
tomayac marked this conversation as resolved.
Outdated
if (!handle) {
throw new Error("Cross-origin storage API returned no handle.");
}
Expand Down
Loading