Skip to content

[Fix] Add origins option to requestFileHandle#19960

Open
tomayac wants to merge 3 commits into
apache:mainfrom
tomayac:patch-1
Open

[Fix] Add origins option to requestFileHandle#19960
tomayac wants to merge 3 commits into
apache:mainfrom
tomayac:patch-1

Conversation

@tomayac

@tomayac tomayac commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

This makes the resources available globally. Initially this wasn't implemented in the extension, but the origins check is implemented now, so we need to update the code to make use of it. (Internally, the extension as a one-off upgrades all resources that were stored already as origins: '*'.)

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the requestFileHandle call in web/src/artifact_cache.ts to include an origins option. However, the CrossOriginStorageRequestFileHandleOptions interface needs to be updated to include this new property to avoid a TypeScript compilation error.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread web/src/artifact_cache.ts Outdated
@tomayac tomayac changed the title Add origins option to requestFileHandle [Fix] Add origins option to requestFileHandle Jul 6, 2026
@tomayac

tomayac commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

By the way, we also now offer TypeScript types.

@tomayac

tomayac commented Jul 11, 2026

Copy link
Copy Markdown
Contributor Author

@akaashrp This PR may be quick to review for you?

@akaashrp akaashrp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akaashrp

Copy link
Copy Markdown
Contributor

Thanks @tomayac, could you retrigger CI?

Comment thread web/src/artifact_cache.ts Outdated
@tomayac

tomayac commented Jul 11, 2026

Copy link
Copy Markdown
Contributor Author

CI fails, but I don't think because of me 🫣?!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants