Skip to content

Adapt HLL backend to CCCL stream-first API #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sleeepyjack merged 1 commit into from
Jul 9, 2026
+5 −5
Merged

Adapt HLL backend to CCCL stream-first API #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions include/datasketches/cuda/detail/hll/sketch_impl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ struct sketch_impl {
::datasketches::target_hll_type tgt)
: lg_config_k_(lgK),
tgt_(check_target_(tgt)),
inner_(std::move(mr), precision{static_cast<int>(lgK)}, policy_type{}, stream)
inner_(stream, std::move(mr), precision{static_cast<int>(lgK)}, policy_type{})
{
}

Expand Down Expand Up @@ -210,13 +210,13 @@ struct sketch_impl {
template <class InputIt>
void update(::cuda::stream_ref s, InputIt first, InputIt last)
{
inner_.add(first, last, s);
inner_.add(s, first, last);
}

template <class InputIt>
void update_async(::cuda::stream_ref s, InputIt first, InputIt last)
{
inner_.add_async(first, last, s);
inner_.add_async(s, first, last);
}

double get_estimate(::cuda::stream_ref s) const
Expand Down Expand Up @@ -249,13 +249,13 @@ struct sketch_impl {
template <class OtherMR, ::cuda::thread_scope OtherScope>
void merge(::cuda::stream_ref s, const sketch_impl<Key, OtherMR, OtherScope>& other)
{
inner_.merge(other.inner_, s);
inner_.merge(s, other.inner_);
}

template <class OtherMR, ::cuda::thread_scope OtherScope>
void merge_async(::cuda::stream_ref s, const sketch_impl<Key, OtherMR, OtherScope>& other)
{
inner_.merge_async(other.inner_, s);
inner_.merge_async(s, other.inner_);
}

std::uint8_t get_lg_config_k() const noexcept { return lg_config_k_; }
Expand Down
Loading