Adapt HLL backend to CCCL stream-first API#3
Merged
Conversation
PointKernel
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the CUDA HLL API and backend for the CCCL cudax HyperLogLog API change merged in NVIDIA/cccl#9720.
That CCCL change makes stream and memory resource arguments explicit and stream-first in the cudax
hyperloglogconstructors and member functions. This PR updates Datasketches CUDA to follow the same style, so its public API and downstream cudax forwarding code match the CCCL GPU-container convention.CCCL PR: NVIDIA/cccl#9720
Changes
hyperloglogbackend forwarding for:addadd_asyncmergemerge_async