Skip to content

Stop commenting on benchmark performance alerts #7447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
khsrali wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Stop commenting on benchmark performance alerts #7447

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/workflows/benchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,10 @@ jobs:
commit-msg-append: '[ci skip]'
github-token: ${{ secrets.GITHUB_TOKEN }}
auto-push: true
# Show alert with commit comment on detecting possible performance regression
# Timings on shared CI runners are too noisy for commit-to-commit alerts to be
# meaningful, so only record the data. Trends are tracked via the rendered charts
# published to the `gh-pages` branch.
alert-threshold: 200%
comment-on-alert: true
comment-on-alert: false
fail-on-alert: false
alert-comment-cc-users: '@giovannipizzi,@agoscinski,@GeigerJ2,@khsrali,@unkcpz'
if: github.event_name == 'push' && github.ref_name == 'main'
Loading