Skip to content

Stop commenting on benchmark performance alerts - #7447

Open
khsrali wants to merge 1 commit into
aiidateam:mainfrom
khsrali:fix/benchmark-alert-comments
Open

Stop commenting on benchmark performance alerts#7447
khsrali wants to merge 1 commit into
aiidateam:mainfrom
khsrali:fix/benchmark-alert-comments

Conversation

@khsrali

@khsrali khsrali commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator
image

Unnecessarily load alert, commented on each PR merge.

Timings measured on shared GitHub runners are too noisy for
commit-to-commit comparisons, so the alerts fired regularly without
indicating a real regression. The benchmark data is still recorded and
published to the `gh-pages` branch, where trends remain visible across
many commits.
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The benchmark workflow keeps alert thresholds and alert-induced failures enabled while disabling commit comment notifications and removing configured CC recipients.

Changes

Benchmark alert configuration

Layer / File(s) Summary
Disable benchmark alert comments
.github/workflows/benchmark.yml
The benchmark result step disables alert comments and removes CC recipients while retaining the alert threshold and fail-on-alert setting.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: agoscinski

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the workflow change to disable benchmark alert comment notifications.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@khsrali
khsrali requested a review from agoscinski July 16, 2026 07:16
@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.61%. Comparing base (cd9024c) to head (abaf191).
⚠️ Report is 68 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7447      +/-   ##
==========================================
+ Coverage   80.39%   80.61%   +0.22%     
==========================================
  Files         578      580       +2     
  Lines       46128    46718     +590     
==========================================
+ Hits        37081    37655     +574     
- Misses       9047     9063      +16     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant