Stop commenting on benchmark performance alerts - #7447
Open
khsrali wants to merge 1 commit into
Open
Conversation
Timings measured on shared GitHub runners are too noisy for commit-to-commit comparisons, so the alerts fired regularly without indicating a real regression. The benchmark data is still recorded and published to the `gh-pages` branch, where trends remain visible across many commits.
📝 WalkthroughWalkthroughThe benchmark workflow keeps alert thresholds and alert-induced failures enabled while disabling commit comment notifications and removing configured CC recipients. ChangesBenchmark alert configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7447 +/- ##
==========================================
+ Coverage 80.39% 80.61% +0.22%
==========================================
Files 578 580 +2
Lines 46128 46718 +590
==========================================
+ Hits 37081 37655 +574
- Misses 9047 9063 +16 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unnecessarily load alert, commented on each PR merge.