Repository navigation
Add dynamic PDK preset support - #43
Merged
Merged
Conversation
Contributor
Author
|
@Gerard-Taulats I addressed all the feedback from #41 and cleaned up the history. You're still the Author of this commits! Do you see any issue with those patches here? |
Layer stack configs may carry an optional "pdk_config" section describing the PDK itself and the config directory may hold a "_config_order.yaml" listing the presets in the order they are shown. Extend the schemas and the config check accordingly, and make sure every entry of the order file has a config file. Signed-off-by: Gerard Taulats <gerardtaulats@gmail.com> Signed-off-by: Daniel Schultz <dnltz@aesc-silicon.de>
Replace the hardcoded PDK table with the layer stack configs found in the configs directory, so that users can add their own PDK by dropping a config file next to the shipped ones. The list is read once and refreshed whenever the import dialog opens. Presets are named after their config file unless the file provides an optional "pdk_config" section with a name, a description or a default color schema, and they are listed in the order given by "configs/_config_order.yaml". Signed-off-by: Gerard Taulats <gerardtaulats@gmail.com> Signed-off-by: Daniel Schultz <dnltz@aesc-silicon.de>
Move the names and descriptions of the shipped PDKs from the add-on into their config files and pre-select the realistic color schema for all of them. The order of the presets is kept as it was with the hardcoded table. Signed-off-by: Gerard Taulats <gerardtaulats@gmail.com> Signed-off-by: Daniel Schultz <dnltz@aesc-silicon.de>
Signed-off-by: Gerard Taulats <gerardtaulats@gmail.com> Signed-off-by: Daniel Schultz <dnltz@aesc-silicon.de>
dnltz
force-pushed
the
WIP/dnltz/dynamic-presets
branch
from
August 20, 2026 11:56
10d96a1 to
decbfde
Compare
Contributor
|
I'm so sorry it took me this long to get back to this. So long, you were about to take care of the rest yourself😅. I'll take a look now |
Contributor
|
I reviewed the code and tested. Works like a charm👌 |
Contributor
Author
thanks for testing. I also ran some and it fixed one bug on Metal1. Now worries with not reacting. You almost provided everything and I just had to clean it up :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #41 by @Gerard-Taulats with the open review feedback addressed and a
cleaned up history. The commits keep his authorship.
The hardcoded PDK table is gone: every layer stack config in
import_gdsii/configsis offered as a preset, so users can add their own PDK bydropping a config file next to the shipped ones together with a color schema
directory of the same name. The list is read once and refreshed whenever the
import dialog opens, so a new config shows up without restarting Blender.
A config file may describe itself in an optional
pdk_configsection (name,description,def_color); everything falls back to the file name. The presetorder lives in
configs/_config_order.yaml, so it no longer has to bemaintained across several files. Configs missing from that list are appended in
alphabetical order instead of being dropped.
Changes on top of #41:
ignored before, and the
_placeholder is replaced by the fallback abovef"...{d["key"]}..."fallbacks that are aSyntaxErrorbefore Python3.12 are gone; the config and color paths now come straight from the loaded
config, and an unknown PDK is reported instead of raising
pdk_configis dropped from the layer stack after loading instead of beingskipped in every consumer
warning instead of breaking the add-on
_config_order.yamlentries without a config file now fail the config checkIHP_SG13G2fallbacks, the unusedorderschema field andthe whitespace noise are removed
Note: the SiEPIC preset identifier changes from
SIEPIC_EBEAMtoSIEPIC,since identifiers are derived from the config file name (
siepic.yaml).Tested with Blender 4.3.2: importing with a built-in PDK, with a custom config
and color schema, and with an unknown PDK stored in the scene, plus
toxonevery commit.