Add dynamic preset support by Gerard-Taulats · Pull Request #41 · aesc-silicon/BlenderGDS

Gerard-Taulats · 2026-06-30T13:23:04Z

Removes hardcoded presets, reading the files present at "config" folder.
Allows for users to add their custom presets and be readily available from Blender UI.

A set of new properties have been added to the "config" YAML files under "pdk_config", where name, description, order and default color can be set.
"Order" are integers. Default value is 0. If same value is set, then it's ordered alphabetically.
Since I set order of existing presets greater than 0, any new custom preset added by the user will take preference in the list.

I'm thinking next step to polish stuff is to not have a pre-import popup, and instead choose pdk and color from the import window.

TODO: Update readme.md and schema.json, add "def_color" to presets and make default def_color=""

Signed-off-by: Gerard Taulats <gerardtaulats@gmail.com>

dnltz · 2026-07-09T12:59:39Z

+        key=lambda kv: (kv[1]["order"], kv[0])
+    ))
+
+PDK_CONFIGS = load_pdk_configs()


Don't use a constant variable for those information.

dnltz · 2026-07-09T13:00:52Z

    addon_dir = Path(__file__).parent
-    color_path = addon_dir / PDK_CONFIGS.get(pdk, {}).get('color_path', pdk)
-    schemes = [('realistic', 'Realistic', 'Realistic color scheme')]
+    pdf_dict = PDK_CONFIGS.get(pdk, {})


Call load_pdk_configs instead of the constant.

I'm having mixed feelings about this. This constant is being used across 7 functions. While that'd help to maintain latest folder status, I think it's a bit too much to call this every time. What's the usual way on handling these cases? Is it the way you suggest?🤔

I think the function should be run inside "register_properties", GDSIIPreImportDialog class and Import GDSII class once, and pass around data for functions that need it. What do you think?

Yes, loading it once and storing it internally is the right way. I think I already did this with other data.

Signed-off-by: Gerard Taulats <gerardtaulats@gmail.com>

dnltz · 2026-07-16T08:47:21Z

                pdk_info = PDK_CONFIGS.get(pdk_selection, {})
                addon_dir = Path(__file__).parent
-                yamlfile = addon_dir / pdk_info.get('config_path', 'configs/ihp-sg13g2.yaml')
+                yamlfile = addon_dir / pdk_info.get('config_path', f"configs/{pdk_info["file_name"]}.yaml")


Claude: bug: nested " inside an f-string delimited by " is a SyntaxError before Python 3.12 — this addon targets Blender 3.4+ (older Python), so the module won't even import.

Suggested change

yamlfile = addon_dir / pdk_info.get('config_path', f"configs/{pdk_info["file_name"]}.yaml")

yamlfile = addon_dir / pdk_info.get('config_path', f'configs/{pdk_info["file_name"]}.yaml')

dnltz · 2026-07-16T08:47:21Z

                colorfile = Path(custom_color_path)
            else:
-                color_dir = addon_dir / pdk_info.get('color_path', 'configs/colors/ihp-sg13g2')
+                color_dir = addon_dir / pdk_info.get('color_path', f"configs/colors/{pdk_info["file_name"]}")


Claude: bug: same nested-quote SyntaxError as the yamlfile line above.

Suggested change

color_dir = addon_dir / pdk_info.get('color_path', f"configs/colors/{pdk_info["file_name"]}")

color_dir = addon_dir / pdk_info.get('color_path', f'configs/colors/{pdk_info["file_name"]}')

dnltz · 2026-07-16T08:47:21Z

+                if k not in pdk_order
+            }
+            sorted_pdks.update(dict(sorted(remaining.items())))
+        elif item in pdks.keys():


Claude: bug: _config_order.yaml lists raw file stems (ihp-sg13g2), but pdks is keyed by the uppercased form (IHP_SG13G2) from line 50 — so item in pdks.keys() and k not in pdk_order (line 77) never match, and custom ordering silently falls back to alphabetical every time. Normalize item/pdk_order entries with the same .upper().replace('-', '_') transform used on line 50 before comparing.

dnltz · 2026-07-16T08:47:21Z

        color_file = yaml.safe_load(file.read_text(encoding='utf-8'))
-        schemes.append((file.stem, color_file.get('name', file.stem),
-                       color_file.get('description', file.stem)))
+        if file.stem==pdf_dict["def_color"]:


Claude: bug: if pdk isn't a valid key (e.g. the stale fallback below), pdf_dict is {} and this raises KeyError.

Suggested change

if file.stem==pdf_dict["def_color"]:

if file.stem==pdf_dict.get("def_color"):

dnltz · 2026-07-16T08:47:21Z

-    items = []
+    # TODO: Load only when accessing list or when opening file explorer, not every refresh. Or add a refresh button

    pdk = getattr(context.scene, 'gdsii_pdk_selection', 'IHP_SG13G2')


Claude: nit: this fallback is still the old hardcoded 'IHP_SG13G2' — the rest of this PR switched to next(iter(PDK_CONFIGS)) for the same purpose (lines 625, 638, 777).

Suggested change

pdk = getattr(context.scene, 'gdsii_pdk_selection', 'IHP_SG13G2')

pdk = getattr(context.scene, 'gdsii_pdk_selection', next(iter(PDK_CONFIGS)))

dnltz · 2026-07-16T09:09:55Z

    addon_dir = Path(__file__).parent
-    color_path = addon_dir / PDK_CONFIGS.get(pdk, {}).get('color_path', pdk)
-    schemes = [('realistic', 'Realistic', 'Realistic color scheme')]
+    pdf_dict = PDK_CONFIGS.get(pdk, {})


Yes, loading it once and storing it internally is the right way. I think I already did this with other data.

Gerard-Taulats · 2026-08-22T06:51:19Z

Replaced by #43

Gerard-Taulats added 2 commits June 30, 2026 00:28

Progress

69e5fbb

Signed-off-by: Gerard Taulats <gerardtaulats@gmail.com>

Finish implementation, fix bugs and cleanup

eeb5dad

Signed-off-by: Gerard Taulats <gerardtaulats@gmail.com>

Gerard-Taulats requested a review from dnltz as a code owner June 30, 2026 13:23

Gerard-Taulats marked this pull request as draft June 30, 2026 13:23

Gerard-Taulats added 4 commits July 6, 2026 18:16

Progress

36ccc5c

Signed-off-by: Gerard Taulats <gerardtaulats@gmail.com>

Merge branch 'main' into Gerard-Taulats-dynamic-presets

000c159

Signed-off-by: Gerard Taulats <gerardtaulats@gmail.com>

Set "def_color" for each preset

0160732

Signed-off-by: Gerard Taulats <gerardtaulats@gmail.com>

Add pdk_config to layer_config.schema

028b382

Signed-off-by: Gerard Taulats <gerardtaulats@gmail.com>

Gerard-Taulats force-pushed the Gerard-Taulats-dynamic-presets branch 2 times, most recently from 278f2cb to 89ea42a Compare July 6, 2026 20:55

Update readme

0408b60

Signed-off-by: Gerard Taulats <gerardtaulats@gmail.com>

Gerard-Taulats force-pushed the Gerard-Taulats-dynamic-presets branch from 89ea42a to 0408b60 Compare July 6, 2026 21:00

Gerard-Taulats marked this pull request as ready for review July 6, 2026 21:01

dnltz requested changes Jul 9, 2026

View reviewed changes

Gerard-Taulats added 2 commits July 12, 2026 22:47

Refactor load_pdk_configs

5287418

Signed-off-by: Gerard Taulats <gerardtaulats@gmail.com>

Address review

e3a86bd

Signed-off-by: Gerard Taulats <gerardtaulats@gmail.com>

Gerard-Taulats force-pushed the Gerard-Taulats-dynamic-presets branch from 4b9bab7 to e3a86bd Compare July 12, 2026 21:26

Move order to separate file

5463331

Signed-off-by: Gerard Taulats <gerardtaulats@gmail.com>

Gerard-Taulats force-pushed the Gerard-Taulats-dynamic-presets branch 3 times, most recently from d8f394f to 0173cc8 Compare July 14, 2026 16:38

Typo and order

22fcd80

Signed-off-by: Gerard Taulats <gerardtaulats@gmail.com>

Gerard-Taulats force-pushed the Gerard-Taulats-dynamic-presets branch from 0173cc8 to 22fcd80 Compare July 14, 2026 16:39

dnltz reviewed Jul 16, 2026

View reviewed changes

dnltz mentioned this pull request Aug 20, 2026

Add dynamic PDK preset support #43

Merged

Gerard-Taulats closed this Aug 22, 2026

	yamlfile = addon_dir / pdk_info.get('config_path', f"configs/{pdk_info["file_name"]}.yaml")
	yamlfile = addon_dir / pdk_info.get('config_path', f'configs/{pdk_info["file_name"]}.yaml')

	color_dir = addon_dir / pdk_info.get('color_path', f"configs/colors/{pdk_info["file_name"]}")
	color_dir = addon_dir / pdk_info.get('color_path', f'configs/colors/{pdk_info["file_name"]}')

	if file.stem==pdf_dict["def_color"]:
	if file.stem==pdf_dict.get("def_color"):

	pdk = getattr(context.scene, 'gdsii_pdk_selection', 'IHP_SG13G2')
	pdk = getattr(context.scene, 'gdsii_pdk_selection', next(iter(PDK_CONFIGS)))

Conversation

Gerard-Taulats commented Jun 30, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Gerard-Taulats commented Aug 22, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants