-
-
Notifications
You must be signed in to change notification settings - Fork 346
WIP: jpackage exclusion refactoring for windows jdk25 and up #7073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -2168,6 +2168,12 @@ | |||||||||||||||||||||
| <version>17</version> | ||||||||||||||||||||||
| <impl>hotspot</impl> | ||||||||||||||||||||||
| </disable> | ||||||||||||||||||||||
| <disable> | ||||||||||||||||||||||
| <comment>https://github.com/adoptium/aqa-tests/issues/6692</comment> | ||||||||||||||||||||||
| <platform>.*windows.*</platform> | ||||||||||||||||||||||
| <version>25+</version> | ||||||||||||||||||||||
| <impl>hotspot</impl> | ||||||||||||||||||||||
| </disable> | ||||||||||||||||||||||
| </disables> | ||||||||||||||||||||||
| <variations> | ||||||||||||||||||||||
| <variation>Mode150</variation> | ||||||||||||||||||||||
|
|
@@ -2200,6 +2206,44 @@ | |||||||||||||||||||||
| <feature>OpenJCEPlus:nonapplicable</feature> | ||||||||||||||||||||||
| </features> | ||||||||||||||||||||||
| </test> | ||||||||||||||||||||||
| <test> | ||||||||||||||||||||||
| <testCaseName>jdk_tools_win</testCaseName> | ||||||||||||||||||||||
| <comment>https://github.com/adoptium/aqa-tests/issues/6692</comment> | ||||||||||||||||||||||
| <platform>.*windows.*</platform> | ||||||||||||||||||||||
| <version>25+</version> | ||||||||||||||||||||||
| <impl>hotspot</impl> | ||||||||||||||||||||||
|
||||||||||||||||||||||
| <platform>.*windows.*</platform> | |
| <version>25+</version> | |
| <impl>hotspot</impl> | |
| <platformRequirements>os.win,...</platformRequirements> | |
| <versions> | |
| <version>25+</version> | |
| </versions> | |
| <impls> | |
| <impl>hotspot</impl> | |
| </impls> |
Copilot
AI
Apr 28, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The added feature line is indented with spaces rather than the tabs used for surrounding <feature> entries. Please align indentation to match the rest of the <features> block to avoid inconsistent formatting in this XML.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<comment>is used throughout this file inside<disable>blocks as the issue URL, but this new test adds a<comment>element directly under<test>. If the playlist schema is strict, this extra element may not be allowed. Consider using an XML comment (<!-- ... -->) or moving the issue URL into a<disable>entry (even if it’s just informational).