Skip to content

WIP: jpackage exclusion refactoring for windows jdk25 and up - #7073

Open
adamfarley wants to merge 3 commits into
adoptium:masterfrom
adamfarley:separate_jpackage_from_jdk_tools
Open

WIP: jpackage exclusion refactoring for windows jdk25 and up#7073
adamfarley wants to merge 3 commits into
adoptium:masterfrom
adamfarley:separate_jpackage_from_jdk_tools

Conversation

@adamfarley

Copy link
Copy Markdown
Contributor

Various jpackage tests fail due to a single issue

However, some are intermittent, and it is unreliable to exclude a fixed list of individual testcases.

So this change prevents all jpackage tests from running on windows for jdk25 and up, while allowing the other jdk_tools tests to run.

Change also excludes formatting improvements and a test unexclusion for jpackage tests logged against a pair of resolved issues.

Note: Change untested. Putting this on the backburner until April release is done.

Various jpackage tests fail due to a single issue

However, some are intermittent, and it is unreliable to exclude a
fixed list of individual testcases.

So this change prevents all jpackage tests from running on windows
for jdk25 and up, while allowing the other jdk_tools tests to run.

Change also excludes formatting improvements and a test unexclusion
for jpackage tests logged against a pair of resolved issues.

Signed-off-by: Adam Farley <adfarley@ibm.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors OpenJDK jdk_tools exclusions to avoid intermittently failing jpackage tests on Windows for JDK 25+, while still running other tool tests.

Changes:

  • Disable the existing jdk_tools playlist entry on Windows for HotSpot JDK 25+ and introduce a new Windows-only jdk_tools_win entry intended to run a reduced subset (excluding jpackage).
  • Remove per-test jpackage exclusions for issue #6692 from Eclipse vendor ProblemLists for OpenJDK 25/26.
  • Remove a few jpackage exclusions for a reportedly resolved issue and apply minor whitespace formatting in ProblemList files.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
openjdk/playlist.xml Adds a Windows JDK 25+ disable for jdk_tools and introduces jdk_tools_win to run a reduced tool test set.
openjdk/excludes/vendors/eclipse/ProblemList_openjdk26.txt Removes many Windows jpackage excludes tied to #6692.
openjdk/excludes/vendors/eclipse/ProblemList_openjdk25.txt Removes many Windows jpackage excludes tied to #6692.
openjdk/excludes/ProblemList_openjdk26.txt Removes a few jpackage excludes (resolved issue) and adds blank lines.
openjdk/excludes/ProblemList_openjdk25.txt Removes a few jpackage excludes (resolved issue) and adds blank lines.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread openjdk/playlist.xml
Comment on lines +2242 to +2244
<feature>FIPS140_3_OpenJCEPlusFIPS.FIPS140-3:nonapplicable</feature>
<feature>FIPS140_3_OpenJCEPlusFIPS.FIPS140-3-Strongly-Enforced:nonapplicable</feature>
<feature>OpenJCEPlus:nonapplicable</feature>

Copilot AI Apr 28, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The added feature line is indented with spaces rather than the tabs used for surrounding <feature> entries. Please align indentation to match the rest of the <features> block to avoid inconsistent formatting in this XML.

Copilot uses AI. Check for mistakes.
Comment thread openjdk/playlist.xml Outdated
Comment on lines +2212 to +2214
<platform>.*windows.*</platform>
<version>25+</version>
<impl>hotspot</impl>

Copilot AI Apr 28, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new jdk_tools_win test uses <platform>, <version>, and <impl> directly under <test>, but elsewhere in this playlist the test-level selectors are expressed via <platformRequirements>, <versions>, and <impls> blocks (e.g., jdk_lang_native_win). If the playlist consumer validates against the expected schema, these fields may be ignored or cause parsing/validation failures, meaning this test could run in the wrong environments (or not at all). Please switch to the established elements (<platformRequirements>os.win,...</platformRequirements>, <versions><version>25+</version></versions>, <impls><impl>hotspot</impl></impls>).

Suggested change
<platform>.*windows.*</platform>
<version>25+</version>
<impl>hotspot</impl>
<platformRequirements>os.win,...</platformRequirements>
<versions>
<version>25+</version>
</versions>
<impls>
<impl>hotspot</impl>
</impls>

Copilot uses AI. Check for mistakes.
Comment thread openjdk/playlist.xml
</test>
<test>
<testCaseName>jdk_tools_win</testCaseName>
<comment>https://github.com/adoptium/aqa-tests/issues/6692</comment>

Copilot AI Apr 28, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<comment> is used throughout this file inside <disable> blocks as the issue URL, but this new test adds a <comment> element directly under <test>. If the playlist schema is strict, this extra element may not be allowed. Consider using an XML comment (<!-- ... -->) or moving the issue URL into a <disable> entry (even if it’s just informational).

Suggested change
<comment>https://github.com/adoptium/aqa-tests/issues/6692</comment>
<!-- https://github.com/adoptium/aqa-tests/issues/6692 -->

Copilot uses AI. Check for mistakes.
As the issue is due to our version of Wix being later than expected.

Signed-off-by: Adam Farley <adfarley@ibm.com>
Altering elements to standardise the jdk_tools_win platform,
and also to replace spaces with tabs where appropriate.

Signed-off-by: Adam Farley <adfarley@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants