[hindi] Cleanup PO file by driusan · Pull Request #10736 · aces/Loris

driusan · 2026-07-02T15:29:48Z

The Hindi translations were the first done, and in some cases the po files have drifted out of sync with the pot file either because the code changed, or the exact wording changed.

This cleans up the strings that are unused in the code that are referenced in the Hindi po file that don't have an entry in the pot file, except for the issue tracker. (The issue tracker have a significant amount that need to be validating if they should be removed from the hindi or added to the pot to get them in sync.)

Resolves # (Reference the issue this fixes, if any.)

HachemJ · 2026-07-02T19:20:43Z


-msgid "The email address is not valid."
+msgid "Email is not valid."
 msgstr "ईमेल पता मान्य नहीं है."


This is outside the scope of this PR but I do not like replacing "The email address is not valid." by "Email is not valid.".
I do think that "The email address is not valid." is the better version because of the following use case :

If we don't want to modify that again as part of this PR, I doubt that my below suggestion makes sense because the current hindi translation conveys the right information, it just doesn't match the msgid correctly.

Suggested change

msgstr "ईमेल पता मान्य नहीं है."

msgstr "ईमेल मान्य नहीं है।"

Current

Recommended

It doesn't need to match the msgid exactly, it needs to make sense and sound natural to a native speaker who is using LORIS. I do not speak or read any hindi at all, so I can't evaluate which one makes more sense. "The email address is not valid." doesn't exist in the code, so I left the old translation with the updated msgid because that was already there.

@skarya22 you're the closest we have to a native hindi speaker, what translation do you like?

The current version is better for what the form requires. But yeah I think that the module should say in english "The email address is not valid" instead of "Email not valid" anyway like Jad said

HachemJ · 2026-07-02T19:46:00Z

Sorry for the missing spaces. I messed up with the GitHub reviewing tool.

I'm waiting on @skarya22 to validate the version preferred so I can approve the changes.

The Hindi translations were the first done, and in some cases the po files have drifted out of sync with the pot file either because the code changed, or the exact wording changed. This cleans up the strings that are unused in the code that are referenced in the Hindi po file that don't have an entry in the pot file, except for the issue tracker. (The issue tracker have a significant amount that need to be validating if they should be removed from the hindi or added to the pot to get them in sync.)

Co-authored-by: Jad El Hachem <156138084+HachemJ@users.noreply.github.com>

driusan · 2026-07-21T18:10:42Z

@HachemJ @skarya22 Rebased and I think I resolve the discussion, can you re-review?

HachemJ · 2026-07-21T18:32:20Z

-msgid "Email is not valid."
-msgstr "विद्युतडाक मान्य नहीं है।"


You have to either adapt the code to use the new/other version of the string "The email address is not valid." or revert this change.

HachemJ · 2026-07-21T18:39:34Z

-msgid "status!"
-msgstr "स्थिति!"


You could either leave this change as is (deleting 'status!' translation) or just adapt it like the others locale to 'Updated {{name}} status!' and its corresponding translation in Hindi.

Here's what I got using AI

msgid "Updated {{name}} status!" msgstr "{{name}} की स्थिति अपडेट कर दी गई!"

on your branch:

HachemJ · 2026-07-21T18:46:16Z

 msgstr "स्पष्टता और अद्वितीयता के लिए उपयोगकर्ता नाम के रूप में ईमेल पते का उपयोग करने की अनुशंसा की जाती है।"

-msgid "When generating a new password, please notify the user by checking 'Send email to user' box"
+msgid "When generating a new password, please notify the user by checking 'Send email to user' box below!"


on your branch:

correct code change. I would maybe adapt this miss from code in the same PR because it is related to that string.

it's missing the word below! at the end of the string.

That looks like a bug in general.. all the other languages (and the pot) have "below!" in the msgid. Just pushed a commit to fix it here

HachemJ · 2026-07-21T18:52:51Z

 msgstr "न्यूनतम आयु (दिन)"
-
-msgid "An error occurred while saving the test."
-msgstr "परीक्षण सहेजते समय एक त्रुटि हुई।"


why did you remove this string? it is referenced in code (battery_manager namespace), it is present in .pot too and every other language.

your branch:

HachemJ · 2026-07-21T18:55:14Z

-
-msgid "An error occurred while saving the test."
-msgstr "परीक्षण सहेजते समय एक त्रुटि हुई।"
-
-msgid "This will deactivate the current test."
-msgstr "इससे वर्तमान परीक्षण निष्क्रिय हो जाएगा।"
-
-msgid "Unspecified Request"
-msgstr "अनिर्दिष्ट अनुरोध"
-
-msgid "This Test already exists in the database"
-msgstr "यह परीक्षण पहले से ही डेटाबेस में मौजूद है।"
-
-msgid "Edit Permission Denied"
-msgstr "संपादन की अनुमति अस्वीकृत"
-
-msgid "Could not add entry to the Test Battery"
-msgstr "परीक्षण बैटरी में प्रविष्टि जोड़ना संभव नहीं हुआ।"


all of them actually. I think that this change should be reverted.

There was a conflict when I rebased and I thought the conflict was that they were supposed to be removed, might have resolved it the wrong way, will re-add

makes sense ok

HachemJ

LGTM

driusan assigned HachemJ Jul 2, 2026

driusan added Multilingual Any tasks related to making LORIS multilingual 29.0.0 - Bugs Issues found during the release testing for 29.0.0 labels Jul 2, 2026

driusan mentioned this pull request Jul 2, 2026

[tools] Add language_completion_check script #10739

Open

HachemJ reviewed Jul 2, 2026

View reviewed changes

Comment thread modules/module_manager/locale/hi/LC_MESSAGES/module_manager.po

HachemJ reviewed Jul 2, 2026

View reviewed changes

Comment thread modules/module_manager/locale/hi/LC_MESSAGES/module_manager.po

HachemJ reviewed Jul 2, 2026

View reviewed changes

Comment thread modules/imaging_uploader/locale/hi/LC_MESSAGES/imaging_uploader.po

driusan commented Jul 2, 2026

View reviewed changes

Comment thread modules/module_manager/locale/hi/LC_MESSAGES/module_manager.po

driusan commented Jul 2, 2026

View reviewed changes

Comment thread modules/module_manager/locale/hi/LC_MESSAGES/module_manager.po

driusan force-pushed the HindiPoCleanup branch from 5fe5227 to 9ed955e Compare July 2, 2026 19:50

Dave MacFarlane and others added 6 commits July 21, 2026 14:07

Duplicate string

c11b573

Use interpolated string

2e37b22

Co-authored-by: Jad El Hachem <156138084+HachemJ@users.noreply.github.com>

More interpolation

6bc24ea

Co-authored-by: Jad El Hachem <156138084+HachemJ@users.noreply.github.com>

Interpolate HTTP response code

449d7e9

Co-authored-by: Jad El Hachem <156138084+HachemJ@users.noreply.github.com>

space between msgids

b7dea3d

driusan force-pushed the HindiPoCleanup branch from 9ed955e to b7dea3d Compare July 21, 2026 18:07

change wording

491445c

HachemJ reviewed Jul 21, 2026

View reviewed changes

add string

f074e42

driusan force-pushed the HindiPoCleanup branch from c1f0431 to f074e42 Compare July 21, 2026 18:39

HachemJ reviewed Jul 21, 2026

View reviewed changes

Added "below"

767aa94

github-actions Bot added the Language: PHP PR or issue that update PHP code label Jul 21, 2026

Dave MacFarlane added 2 commits July 21, 2026 15:01

readd strings

ba93b9a

update msg

4a88c91

HachemJ approved these changes Jul 21, 2026

View reviewed changes

HachemJ added the Passed manual tests PR has been successfully tested by at least one peer label Jul 21, 2026

driusan merged commit 52b1d2f into aces:29.0-release Jul 21, 2026
21 checks passed

	msgstr "ईमेल पता मान्य नहीं है."
	msgstr "ईमेल मान्य नहीं है।"

		msgid "Email is not valid."
		msgstr "विद्युतडाक मान्य नहीं है।"

Uh oh!

Conversation

driusan commented Jul 2, 2026

Uh oh!

HachemJ Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

driusan Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

skarya22 Jul 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

HachemJ commented Jul 2, 2026

Uh oh!

driusan commented Jul 21, 2026

Uh oh!

HachemJ Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

driusan Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

HachemJ Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

HachemJ Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

driusan Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HachemJ Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

HachemJ Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

driusan Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

HachemJ Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

HachemJ left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

HachemJ Jul 2, 2026 •

edited

Loading

driusan Jul 2, 2026 •

edited

Loading

HachemJ Jul 21, 2026 •

edited

Loading

HachemJ Jul 21, 2026 •

edited

Loading

driusan Jul 21, 2026 •

edited

Loading