Skip to content

Toolbar: Spin the Updates icon in the direction of its arrows - #16100

Closed
mukeshpanchal27 wants to merge 1 commit into
WordPress:trunkfrom
mukeshpanchal27:fix/animation-direction
Closed

mukeshpanchal27 wants to merge 1 commit into
WordPress:trunkfrom
mukeshpanchal27:fix/animation-direction

Conversation

@mukeshpanchal27

@mukeshpanchal27 mukeshpanchal27 commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

The Updates icon in the toolbar is now an SVG from the icon library, since r65223. Its two arrows point counterclockwise, but while plugins or themes update, the rotation animation spins it clockwise, from 0deg to 359deg. So the icon spins against its arrows.

This PR adds reverse to the animation, so the icon spins the way its arrows point.

  • Only #wpadminbar #wp-admin-bar-updates.spin .ab-icon svg changes. The toolbar is the only place that uses the core-admin/update icon. The other update spinners in common.css use the Dashicons font and are unchanged.
  • The prefers-reduced-motion: reduce rule still turns the animation off.
  • The spin class is only added by updates.js in the admin, so the front end is not affected.

This is a regression from r65223 in the 7.2 cycle.

Trac ticket: Regression from #65089.

Before:

Screen.Recording.2026-11-19.at.1.41.47.PM.mov

After:

Screen.Recording.2026-11-19.at.1.42.26.PM.mov

Testing Instructions

  1. Go to Plugins > Installed Plugins on a site with a plugin update available.
  2. Click "Update now" for the plugin.
  3. While it updates, watch the Updates icon in the toolbar. It spins counterclockwise, the way its arrows point.

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Drafting this description.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@mukeshpanchal27 mukeshpanchal27 self-assigned this Nov 19, 2026
@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@mukeshpanchal27 mukeshpanchal27 changed the title Reverse animation direction for updates icon Toolbar: Spin the Updates icon in the direction of its arrows Nov 19, 2026
@mukeshpanchal27
mukeshpanchal27 marked this pull request as ready for review November 19, 2026 10:00
@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props mukesh27, wildworks, lancewillett, joen.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub or WordPress.org user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

There are no active review issues for the toolbar Updates icon animation change.

No open issues 🎉

What changed in this PR

Corrects the toolbar Updates icon’s spin direction to match its counterclockwise SVG arrows, addressing the regression introduced in r65223.

Changes:

  • Adds reverse to the icon’s animation while preserving its timing, reduced-motion behavior, and other update spinners.
File Description
src/​wp-includes/​css/​admin-bar.css Reverses the toolbar Updates SVG animation to match its arrows.

Review effort: Balanced

@t-hamano t-hamano left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Per the announcement in #core (https://wordpress.slack.com/archives/C02RQBWTW/p1794943373144399), only fixes for regressions introduced during the 7.2 cycle, or Build/Test Tools changes, can be committed to trunk until 7.2 is branched. This PR fixes a regression from https://core.trac.wordpress.org/changeset/64583, so I think it can be committed to trunk now.

@t-hamano t-hamano left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I approved this PR earlier, but on second thought, I'd like to hold off for a moment.

This PR adds reverse to the animation, so the icon spins the way its arrows point.

Before going this route, I think we should first discuss whether the counterclockwise arrows in the SVG icon are intentional, or whether the icon itself should be flipped instead.

This icon was introduced in WordPress/gutenberg#46575, and there was no discussion about the direction of the arrows.

@WordPress/gutenberg-design, should we flip the arrows to match the Dashicon?

SVG (update) Dashicons (dashicons-update) Dashicons (dashicons-update-alt)
update-svg dashicons-update dashicons-update-alt

@jasmussen

Copy link
Copy Markdown

Thanks for prompt reaction. I saw it too, and in fact I'm working on a redesign of the update icon so that it can spin perfectly without feeling lopsided. Its squarish shape was never designed to rotate, so I think a redesign may be needed. That may answer @t-hamano's concern above aswell, so I will return with an SVG as soon as I can.

@mukeshpanchal27

Copy link
Copy Markdown
Member Author

Thanks for the prompt review!

@t-hamano @jasmussen Are you planning to update the existing icon or introduce a new one? Also, will this be included in the Core PR or handled separately in the Gutenberg repo?

@jasmussen

Copy link
Copy Markdown

Here's what I have. Before and after, left right:

image

That also answers the question: we update the existing icon.

Here's how it rotates, which should now be pure and uniform:

state

Here's the SVG, raw export. I'll put that in a new PR in a minute, but for speed of review wanted to share it here first:

<svg width="24" height="24" viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg">
<path d="M10.5 5.5H11.25V4.75H10.5V5.5ZM8 8L8.53033 8.53033V8.53033L8 8ZM13.5 18.5H12.75V19.25H13.5V18.5ZM14.25 15.25V14.5H12.75V15.25H13.5H14.25ZM16.75 19.25H17.5V17.75H16.75V18.5V19.25ZM9.75 8.75V9.5H11.25V8.75H10.5H9.75ZM7.25 4.75H6.5V6.25H7.25V5.5V4.75ZM10.5 5.5L9.96967 4.96967L7.46967 7.46967L8 8L8.53033 8.53033L11.0303 6.03033L10.5 5.5ZM13.5 18.5L14.0303 19.0303L16.5303 16.5303L16 16L15.4697 15.4697L12.9697 17.9697L13.5 18.5ZM13.5 18.5H14.25V15.25H13.5H12.75V18.5H13.5ZM13.5 18.5V19.25H16.75V18.5V17.75H13.5V18.5ZM10.5 5.5H9.75V8.75H10.5H11.25V5.5H10.5ZM10.5 5.5V4.75H7.25V5.5V6.25H10.5V5.5ZM16 16L16.5303 16.5303C19.0324 14.0283 19.0324 9.9717 16.5303 7.46967L16 8L15.4697 8.53033C17.3859 10.4466 17.3859 13.5534 15.4697 15.4697L16 16ZM8 8L7.46967 7.46967C4.96764 9.9717 4.96764 14.0283 7.46967 16.5303L8 16L8.53033 15.4697C6.61408 13.5534 6.61409 10.4466 8.53033 8.53033L8 8Z" fill="black"/>
</svg>

@jasmussen

Copy link
Copy Markdown

Here's a PR that should both make the rotation smooth, and address the rotation direction issues: WordPress/gutenberg#87088

@lancewillett lancewillett left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mukeshpanchal27. I verified in Chrome that your CSS makes the current icon turn with its arrows and that reduced motion still disables the animation.

Please hold this change while Joen’s icon update is in progress. Its arrows point clockwise, so keeping reverse after the icon sync would bring the mismatch back. Once the new SVG reaches Core, let’s check the toolbar during a plugin update. If the arrows follow the spin, we can close this PR as superseded. Gutenberg icon PR

AI review · gpt-6

@jasmussen

Copy link
Copy Markdown

As an update, we have agreement for an update to the icon itself that addresses the primary concern; the icon still probably needs to be ported over (CC: @fushar for nuance), but that should unblock the shipping version.

@mukeshpanchal27

Copy link
Copy Markdown
Member Author

@jasmussen Can we mark this PR as closed?

@jasmussen

Copy link
Copy Markdown

WordPress/gutenberg#87088 has been merged. Do you mean this one?

@mukeshpanchal27

Copy link
Copy Markdown
Member Author

Do you mean this one?

I mean this core PR. As that icon will ship when the GB changes pushed to core.

@jasmussen

Copy link
Copy Markdown

I'll close this one then, thanks all for contributing.

@jasmussen jasmussen closed this Nov 19, 2026
@mukeshpanchal27
mukeshpanchal27 deleted the fix/animation-direction branch November 19, 2026 15:19
@fcoveram

Copy link
Copy Markdown

I created a new version, in addition to other icon updates, here gutenberg#87101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants