Repository navigation
Toolbar: Spin the Updates icon in the direction of its arrows - #16100
mukeshpanchal27 wants to merge 1 commit into
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues for the toolbar Updates icon animation change.
No open issues 🎉
What changed in this PR
Corrects the toolbar Updates icon’s spin direction to match its counterclockwise SVG arrows, addressing the regression introduced in r65223.
Changes:
- Adds
reverseto the icon’s animation while preserving its timing, reduced-motion behavior, and other update spinners.
| File | Description |
|---|---|
src/wp-includes/css/admin-bar.css |
Reverses the toolbar Updates SVG animation to match its arrows. |
Review effort: Balanced
t-hamano
left a comment
There was a problem hiding this comment.
Nice catch!
Per the announcement in #core (https://wordpress.slack.com/archives/C02RQBWTW/p1794943373144399), only fixes for regressions introduced during the 7.2 cycle, or Build/Test Tools changes, can be committed to trunk until 7.2 is branched. This PR fixes a regression from https://core.trac.wordpress.org/changeset/64583, so I think it can be committed to trunk now.
There was a problem hiding this comment.
Sorry, I approved this PR earlier, but on second thought, I'd like to hold off for a moment.
This PR adds
reverseto the animation, so the icon spins the way its arrows point.
Before going this route, I think we should first discuss whether the counterclockwise arrows in the SVG icon are intentional, or whether the icon itself should be flipped instead.
This icon was introduced in WordPress/gutenberg#46575, and there was no discussion about the direction of the arrows.
@WordPress/gutenberg-design, should we flip the arrows to match the Dashicon?
SVG (update) |
Dashicons (dashicons-update) |
Dashicons (dashicons-update-alt) |
|---|---|---|
![]() |
![]() |
![]() |
|
Thanks for prompt reaction. I saw it too, and in fact I'm working on a redesign of the update icon so that it can spin perfectly without feeling lopsided. Its squarish shape was never designed to rotate, so I think a redesign may be needed. That may answer @t-hamano's concern above aswell, so I will return with an SVG as soon as I can. |
|
Thanks for the prompt review! @t-hamano @jasmussen Are you planning to update the existing icon or introduce a new one? Also, will this be included in the Core PR or handled separately in the Gutenberg repo? |
|
Here's a PR that should both make the rotation smooth, and address the rotation direction issues: WordPress/gutenberg#87088 |
lancewillett
left a comment
There was a problem hiding this comment.
Thanks, @mukeshpanchal27. I verified in Chrome that your CSS makes the current icon turn with its arrows and that reduced motion still disables the animation.
Please hold this change while Joen’s icon update is in progress. Its arrows point clockwise, so keeping reverse after the icon sync would bring the mismatch back. Once the new SVG reaches Core, let’s check the toolbar during a plugin update. If the arrows follow the spin, we can close this PR as superseded. Gutenberg icon PR
AI review · gpt-6
|
As an update, we have agreement for an update to the icon itself that addresses the primary concern; the icon still probably needs to be ported over (CC: @fushar for nuance), but that should unblock the shipping version. |
|
@jasmussen Can we mark this PR as closed? |
|
WordPress/gutenberg#87088 has been merged. Do you mean this one? |
I mean this core PR. As that icon will ship when the GB changes pushed to core. |
|
I'll close this one then, thanks all for contributing. |
|
I created a new version, in addition to other icon updates, here gutenberg#87101 |





The Updates icon in the toolbar is now an SVG from the icon library, since r65223. Its two arrows point counterclockwise, but while plugins or themes update, the
rotationanimation spins it clockwise, from0degto359deg. So the icon spins against its arrows.This PR adds
reverseto the animation, so the icon spins the way its arrows point.#wpadminbar #wp-admin-bar-updates.spin .ab-icon svgchanges. The toolbar is the only place that uses thecore-admin/updateicon. The other update spinners incommon.cssuse the Dashicons font and are unchanged.prefers-reduced-motion: reducerule still turns the animation off.spinclass is only added byupdates.jsin the admin, so the front end is not affected.This is a regression from r65223 in the 7.2 cycle.
Trac ticket: Regression from #65089.
Before:
Screen.Recording.2026-11-19.at.1.41.47.PM.mov
After:
Screen.Recording.2026-11-19.at.1.42.26.PM.mov
Testing Instructions
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Drafting this description.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.