Skip to content

Update the Update icon. - #87088

Merged
jasmussen merged 3 commits into
trunkfrom
update/update-icon
Nov 19, 2026
Merged

jasmussen merged 3 commits into
trunkfrom
update/update-icon

Conversation

@jasmussen

Copy link
Copy Markdown
Contributor

What?

See WordPress/wordpress-develop#16100 (comment) and https://core.trac.wordpress.org/ticket/65089#comment:140

Updates the Update icon to do two things:

  • Rotate evenly, the squarish version didn't
  • Rotate towards the right
state image

Before and after.

Testing Instructions

npm run storybook:dev

Use of AI Tools

Only for the changelog. The icon itself was manually drawn here.

@jasmussen jasmussen self-assigned this Nov 19, 2026
@jasmussen jasmussen added [Type] Enhancement A suggestion for improvement. [Package] Icons /packages/icons labels Nov 19, 2026
@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

🤖 PR meta 🤖

Preview in WordPress Playground Preview in Storybook

🎉 Props

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: jasmussen <joen@git.wordpress.org>
Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org>
Co-authored-by: simison <simison@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

Updated as activity occurs, without notifying anyone named here. Add the props-bot label to refresh.

⚡ Performance

Show the results

Client side metrics exclude the server response time.

front-end-block-theme

Metric 14a2f06 trunk % Change
timeToFirstByte 53.3 ms +7.22% -3.75% 52.6 ms +7.7% -2% 1.33%
largestContentfulPaint 88 ms +9.09% -4.55% 88 ms +6.82% -9.09% 0%
lcpMinusTtfb 33.15 ms +16.74% -6.18% 32.15 ms +18.04% -11.2% 3.11%
wpBeforeTemplate 26.23 ms +10.64% -2.1% 27.41 ms +1.9% -6.64% -4.3%
wpTemplate 22.19 ms +6.49% -3.15% 22.09 ms +10.55% -6.11% 0.45%
wpTotal 48.48 ms +8.77% -2.33% 48.57 ms +8.15% -2.88% -0.19%
wpMemoryUsage 7.75 MB +0% -0% 7.71 MB +0% -0% 0.45%
wpDbQueries 16 +0% -0% 16 +0% -0% 0%

front-end-classic-theme

Metric 14a2f06 trunk % Change
timeToFirstByte 45.5 ms +6.7% -5.82% 43.2 ms +9.49% -3.47% 5.32%
largestContentfulPaint 86 ms +2.33% -6.98% 82 ms +4.88% -7.32% 4.88%
lcpMinusTtfb 38.05 ms +11.7% -2.5% 36.7 ms +14.58% -5.59% 3.68%
wpBeforeTemplate 23.3 ms +18.88% -3.56% 22.2 ms +12.34% -0.86% 4.95%
wpTemplate 16.73 ms +3.77% -2.33% 17.27 ms +7.24% -5.33% -3.13%
wpTotal 40.92 ms +8.21% -3.67% 39.83 ms +9.42% -3.94% 2.74%
wpMemoryUsage 6.44 MB +0% -0% 6.40 MB +0% -0% 0.56%
wpDbQueries 13 +0% -0% 13 +0% -0% 0%

media-processing

Metric 14a2f06 trunk % Change
mediaProcessingJpeg 422.75 ms +0.14% -1.38% 417.26 ms +2.85% -0.46% 1.32%
mediaProcessingAvif 5936.13 ms +0.24% -0.37% 5925.55 ms +0.29% -0.05% 0.18%
mediaProcessingJpegToAvif 4053.63 ms +0.25% -0.25% 4042.39 ms +0.2% -0.2% 0.28%

media-upload

Metric 14a2f06 trunk % Change
jpegUploadProcessing 1993.97 ms +1.7% -22.71% 1765.86 ms +13.7% -14.31% 12.92%
pngUploadProcessing 272.8 ms +4.24% -2.07% 276.43 ms +1.72% -1.3% -1.31%
largeJpegUploadProcessing 1525.01 ms +29.81% -2.06% 1768.52 ms +14.3% -13.44% -13.77%
multipleImageUploadProcessing 2082.69 ms +1.6% -0.27% 2120.37 ms +0.92% -1.59% -1.78%

post-editor

Metric 14a2f06 trunk % Change
serverResponse 489.34 ms +3.45% -8.18% 476.92 ms +1.07% -5.12% 2.6%
firstPaint 458.13 ms +6.71% -9.67% 442.22 ms +9% -8.35% 3.6%
domContentLoaded 835.49 ms +9.15% -2.3% 821.88 ms +3.1% -1.68% 1.66%
loaded 836.78 ms +9.12% -2.3% 823.13 ms +3.06% -1.68% 1.66%
firstContentfulPaint 469.91 ms +13.17% -2.37% 472.08 ms +2.22% -3.83% -0.46%
firstBlock 2259.47 ms +1.48% -2.42% 2204.31 ms +1.42% -1.51% 2.5%
type 16.86 ms +4.39% -11.15% 16.65 ms +6.85% -5.95% 1.26%
typeWithoutInspector 17.13 ms +4.9% -7.3% 16.34 ms +7.53% -6.85% 4.83%
typeWithTopToolbar 22.4 ms +5.27% -5.13% 23.2 ms +4.14% -10.3% -3.45%
typeContainer 8.1 ms +8.77% -12.59% 8.27 ms +5.93% -14.27% -2.06%
focus 119.77 ms +15.63% -7.91% 122.28 ms +2.18% -6.2% -2.05%
firstFocus 287.22 ms +0% -0% 264.3 ms +0% -0% 8.67%
selectAll 405.5 ms +2.84% -1.49% 413.95 ms +5.65% -2.81% -2.04%
undo 29.84 ms +17.9% -4.76% 30.54 ms +4.45% -9.43% -2.29%
listViewOpen 78.9 ms +13% -11.13% 77.67 ms +6.8% -4.88% 1.58%
inserterOpen 43.91 ms +8.52% -15.14% 41.33 ms +22.24% -5.52% 6.24%
inserterHover 11.49 ms +10.88% -14.27% 11.93 ms +7.04% -15.59% -3.69%
inserterSearch 7.96 ms +4.4% -5.03% 8.52 ms +4.11% -14.44% -6.57%
loadPatterns 649.83 ms +5.76% -7.97% 661.38 ms +4.17% -4.08% -1.75%
wpTotal 479.65 ms +3.11% -8.32% 467.26 ms +1.12% -5.3% 2.65%
wpMemoryUsage 14.81 MB +0% -0% 14.77 MB +0% -0% 0.25%
wpDbQueries 55 +0% -0% 55 +0% -0% 0%

site-editor

Metric 14a2f06 trunk % Change
serverResponse 484.98 ms +1.06% -9.47% 469.48 ms +5.03% -4.81% 3.3%
firstPaint 417.2 ms +8.26% -2% 467.77 ms +5.79% -7.79% -10.81%
domContentLoaded 854.42 ms +2.06% -1.39% 872.92 ms +2.63% -0.91% -2.12%
loaded 855.44 ms +2.08% -1.39% 874.14 ms +2.6% -0.92% -2.14%
firstContentfulPaint 480.79 ms +2.47% -3.78% 487.71 ms +3.48% -0.78% -1.42%
firstBlock 2639.53 ms +1.17% -0.47% 2666.59 ms +0.24% -0.99% -1.01%
type 19.18 ms +4.95% -11.63% 18.32 ms +6.28% -8.84% 4.69%
navigate 120.07 ms +10.96% -3.9% 120.89 ms +3.52% -4% -0.68%
loadPatterns 1440.41 ms +1.5% -2.36% 1483.21 ms +5.21% -5.28% -2.89%
loadPages 990.23 ms +0.58% -1.86% 990.12 ms +1.44% -1.94% 0.01%
wpTotal 475.43 ms +1.08% -9.64% 459.91 ms +5.12% -4.92% 3.37%
wpMemoryUsage 12.82 MB +0% -0% 12.79 MB +0% -0% 0.25%
wpDbQueries 45 +0% -0% 45 +0% -0% 0%

c4f7a22 Run

🏁 Flaky tests

Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

Actions are reachable via RIGHT/LEFT arrow keys (Site Editor v2) in /test/e2e/specs/site-editor/dataviews-list-layout-keyboard.spec.js, passed after 1 failed attempt.
Error: expect(locator).toBeFocused() failed

Locator:  getByRole('row', { name: 'Page One View Actions' }).getByLabel('Actions')
Expected: focused
Received: inactive
Timeout:  5000ms

Call log:
  - Expect "toBeFocused" getByRole('row', { name: 'Page One View Actions' }).getByLabel('Actions') with timeout 5000ms
  - waiting for getByRole('row', { name: 'Page One View Actions' }).getByLabel('Actions')
    14 × locator resolved to <button type="button" tabindex="-1" aria-haspopup="menu" aria-label="Actions" aria-expanded="false" id="view-list-0-13-dropdown" class="components-button is-small has-icon">…</button>
       - unexpected value "inactive"

    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/site-editor/dataviews-list-layout-keyboard.spec.js:181:5
As a user I want to be able to add multiple close buttons so that users can close the overlay from different positions in /test/e2e/specs/site-editor/navigation-overlay-template-part.spec.js, passed after 1 failed attempt.
Error: expect(locator).toHaveCount(expected) failed

Locator:  getByRole('button', { name: 'Close' })
Expected: 2
Received: 1
Timeout:  5000ms

Call log:
  - Expect "toHaveCount" getByRole('button', { name: 'Close' }) with timeout 5000ms
  - waiting for getByRole('button', { name: 'Close' })
    14 × locator resolved to 1 element
       - unexpected value "1"

    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/site-editor/navigation-overlay-template-part.spec.js:228:33
should undo without broken temporary state in /test/e2e/specs/editor/blocks/image.spec.js, passed after 1 failed attempt.
Error: expect(received).toBe(expected) // Object.is equality

- Expected  - 2
+ Received  + 2

- <!-- wp:image -->
- <figure class="wp-block-image"><img alt=""/></figure>
+ <!-- wp:image {"id":21,"sizeSlug":"full","linkDestination":"none"} -->
+ <figure class="wp-block-image size-full"><img src="http://localhost:8889/wp-content/uploads/2026/11/9dc084cd-44ca-407a-90cf-f813ffc5b162.png" alt="" class="wp-image-21"/></figure>
  <!-- /wp:image -->
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/image.spec.js:432:49

c4f7a22 Run

@jasmussen
jasmussen requested review from fushar and t-hamano November 19, 2026 11:36
@github-actions
github-actions Bot requested review from aduth and ciampo November 19, 2026 11:36
@mukeshpanchal27

Copy link
Copy Markdown
Member

Needs to update changelog?

@jasmussen

Copy link
Copy Markdown
Contributor Author

Yep, on the way. Just realised an issue in the SVG I made.

The icon was exported from Figma with its stroke outlined, so it landed as
a filled path. That made it one of only two icons in the library with no
stroke, pinned its weight into the path data, and left it unable to respond
to the `strokeWidth` prop. Re-exported from Figma without outlining, and
rounded the float noise in the arc path.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@jasmussen

Copy link
Copy Markdown
Contributor Author

OK, the icon was actually a fill when I first committed, now it's a proper stroke, with a changelog. This is ready.

@jasmussen

Copy link
Copy Markdown
Contributor Author

Hold off one moment, I have another quick possible update before we merged.

image

Asking @fcoveram directly, he suggested this could be closer to the "backup" icon, so unless anyone objects, I think I'll push that version after all.

For the immediate future, we need a 7.2 fix. Longer term, we can always iterate further.

The arcs now sit on the r=7.25 circle that Backup's clock face uses, and the
arrowheads match Backup's: barbs 2.75 across, 2 deep along the tangent. The
two icons share a footprint, so Update no longer reads a size small beside it.

Snapped the exported path to exact 180-degree symmetry and set the points on
the 45-degree diagonals to x = y, correcting float noise from the export of
up to 2e-4. Nothing moves by more than a hundredth of a pixel at 96px.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@jasmussen
jasmussen enabled auto-merge (squash) November 19, 2026 14:46
@jasmussen
jasmussen merged commit bd0c79f into trunk Nov 19, 2026
82 checks passed
@jasmussen
jasmussen deleted the update/update-icon branch November 19, 2026 14:58
@github-actions github-actions Bot added this to the Gutenberg 24.6 milestone Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] Icons /packages/icons [Type] Enhancement A suggestion for improvement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants