fix(unreal): use portable UBT plugin output path - #2368
Open
liu-kaizhi wants to merge 1 commit into
Open
liu-kaizhi wants to merge 1 commit into
liu-kaizhi wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A Linux Unreal build reported
FileNotFoundExceptionwhen UBT tried to loadCSharpParamDefaultValueMetas.dllfromBinaries/DotNET/UnrealBuildTool/Plugins/CSharpParamDefaultValueMetas/. The project spells its relativeOutputPathwith Windows backslashes. Use forward slashes so the output path is portable and points to the directory UBT expects on Linux.Changes
OutputPathinCSharpParamDefaultValueMetas.ubtplugin.csproj.Verification
Unreal_v1.0.9, Linux CI passed all three builds: Game, Editor, and Server. That integration also includes compatibility fixes already present on current PuerTSmaster.Binaries/DotNET/UnrealBuildTool/Plugins/CSharpParamDefaultValueMetas/.git diff --checkpasses with CRLF line endings accounted for.