Skip to content

fix: avoid in-place mutation of param in MTP weight conversion (related to #2131) #2227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
botbikamordehai2-sketch wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: avoid in-place mutation of param in MTP weight conversion (related to #2131) #2227

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion slime/backends/megatron_utils/megatron_to_hf/mimo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,9 @@ def convert_mimo_mtp_param(args, name, param):
"final_layernorm.weight": f"model.mtp_layers.{layer_idx}.final_layernorm.weight",
}
if component == "eh_proj.weight":
# chunk and reorder halves; create new tensor to avoid mutating input
first_half, second_half = param.chunk(2, dim=1)
param = torch.cat([second_half, first_half], dim=1)
param = torch.cat([second_half, first_half], dim=1).contiguous()

# Check direct mappings first
if component in direct_mappings:
Expand Down
Loading