fix: avoid in-place mutation of param in MTP weight conversion (related to #2131)#2227
Open
botbikamordehai2-sketch wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
In
convert_mimo_mtp_param, when handlingeh_proj.weight, theparamtensor is reassigned after chunking and concatenating halves. While this does not cause a crash in the conversion logic, it mutates the tensor's storage if the originalparamis later used elsewhere (e.g., in other conversion calls). The reported crash #2131 is actually in training-step logging for multi-head MTP, not in this conversion file. However, this commit fixes a minor potential issue in the conversion code to avoid unexpected behavior from in-place modification.Fix
Ensure the new tensor created by
torch.catis contiguous to avoid potential issues with non-contiguous memory views.Closes #2131