Skip to content

thio-background-app-notifier: Add version 1.3.1 - #18390

Open
matru wants to merge 3 commits into
ScoopInstaller:masterfrom
matru:master
Open

thio-background-app-notifier: Add version 1.3.1#18390
matru wants to merge 3 commits into
ScoopInstaller:masterfrom
matru:master

Conversation

@matru

@matru matru commented Jul 26, 2026

Copy link
Copy Markdown

@coderabbitai

coderabbitai Bot commented Jul 26, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The Windows app-notifier manifest is updated to version 1.3.1. Its metadata, release download URL, hash, executable name, and shortcut target now reference the 1.3.1 release, while the autoupdate URL remains version-templated.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is too brief and omits required template items like issue linkage and the checklist confirmations. Add a Closes/Relates issue reference, confirm the contributing-guide checks, and include the required checklist items.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title is concise and matches the main change: adding version 1.3.1 for thio-background-app-notifier.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot added the package-request-needed Create a package request issue before raising PR. Check the criteria for a package to be accepted. label Jul 26, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🧹 Nitpick comments (1)
bucket/thio-background-app-notifier.json (1)

1-19: 📐 Maintainability & Code Quality | 🔵 Trivial

Run the manifest checks before submission.

scoop config debug true
scoop config gh_token <your-github-token>  # optional, read-only
.\bin\checkver.ps1 -App thio-background-app-notifier -f
.\bin\formatjson.ps1 -App thio-background-app-notifier
scoop install bucket/thio-background-app-notifier.json -a 64bit
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@bucket/thio-background-app-notifier.json` around lines 1 - 19, Run the
required manifest validation and formatting commands for
thio-background-app-notifier, then install the manifest with the 64-bit
architecture option to verify it passes checks. Fix any validation or formatting
issues reported by checkver.ps1, formatjson.ps1, or the installation command
before submission.

Source: Path instructions

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@bucket/thio-background-app-notifier.json`:
- Around line 5-6: Add the missing commas after the "license" property and the
"shortcuts" array in the Thio-Background-App-Notifier manifest, preserving valid
JSON syntax so Scoop can parse it.
- Around line 2-5: Add a valid Scoop Extras package-request issue link to the
new manifest’s description or associated PR, referencing the issue created
through the package-request template. Keep the existing metadata fields
unchanged and ensure the linked request documents the project’s established
status, stable release, and English documentation/interface.
- Around line 6-8: Update the bin value in the Thio-Background-App-Notifier
manifest to exactly match the executable filename downloaded by the url,
including its versioned naming. Keep the bin entry synchronized whenever the
release URL version changes.
- Around line 11-17: Add an autoupdate.shortcuts entry alongside the existing
autoupdate.url in the bucket manifest, targeting the shortcut executable path
currently containing the fixed 1.3.1 version and templating that version with
the manifest’s $version placeholder. Preserve the existing shortcut display name
and URL update behavior.

---

Nitpick comments:
In `@bucket/thio-background-app-notifier.json`:
- Around line 1-19: Run the required manifest validation and formatting commands
for thio-background-app-notifier, then install the manifest with the 64-bit
architecture option to verify it passes checks. Fix any validation or formatting
issues reported by checkver.ps1, formatjson.ps1, or the installation command
before submission.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 2e09b1a3-ca5f-4887-b40c-68981bb882a6

📥 Commits

Reviewing files that changed from the base of the PR and between dd20491 and 312e858.

📒 Files selected for processing (1)
  • bucket/thio-background-app-notifier.json

Comment thread bucket/thio-background-app-notifier.json Outdated
Comment thread bucket/thio-background-app-notifier.json Outdated
Comment thread bucket/thio-background-app-notifier.json Outdated
Comment thread bucket/thio-background-app-notifier.json Outdated
@coderabbitai coderabbitai Bot removed the package-request-needed Create a package request issue before raising PR. Check the criteria for a package to be accepted. label Jul 26, 2026
@aliesbelik aliesbelik added the package-request-needed Create a package request issue before raising PR. Check the criteria for a package to be accepted. label Jul 27, 2026
@z-Fng z-Fng changed the title Support for Thio Background App Notifier thio-background-app-notifier: Add version 1.3.1 Jul 29, 2026
@aliesbelik aliesbelik linked an issue Aug 1, 2026 that may be closed by this pull request
6 tasks
@aliesbelik aliesbelik removed the package-request-needed Create a package request issue before raising PR. Check the criteria for a package to be accepted. label Aug 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request]: Thio Background App Notifier

2 participants