faster-dooit: Add version 0.1.0 - #18463
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds a Scoop manifest for Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
coderabbitai
Bot
added
not-meet-criteria
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
bucket/faster-dooit.json (1)
17-23: 📐 Maintainability & Code Quality | 🔵 TrivialRun the required manifest checks before submission.
scoop config debug true # Optional: scoop config gh_token <your-github-token> .\bin\checkver.ps1 -App faster-dooit -f .\bin\formatjson.ps1 -App faster-dooit scoop install bucket/faster-dooit.json -a 64bit $raw = [IO.File]::ReadAllText("bucket/faster-dooit.json") if ($raw -match "(?<!`r)`n") { throw "Manifest uses LF line endings; Scoop manifests require CRLF." }As per path instructions, validate version detection, formatting, installation, architecture behavior, and CRLF line endings locally.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/faster-dooit.json` around lines 17 - 23, Before submitting faster-dooit.json, run the required manifest validation steps with checkver.ps1, formatjson.ps1, and a 64-bit scoop install, then verify the file still uses CRLF line endings. Use the existing autoupdate and hash entries in faster-dooit.json as the manifest under test, and fix any version-detection, formatting, installation, or line-ending issues surfaced by those checks before resubmitting.Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@bucket/faster-dooit.json`:
- Around line 6-7: Restrict the manifest to the supported Windows AMD64 artifact
by moving the top-level url and hash entries, along with the binary mapping and
the matching autoupdate.architecture.64bit settings, under the
architecture.64bit block in the faster-dooit manifest. Keep the existing AMD64
values unchanged and leave no top-level download fields that could be selected
for unsupported Windows ARM64 hosts.
- Around line 8-12: Update the binary entry in the Scoop manifest’s bin mapping
to use the release-produced name fdooit.exe while preserving fdooit as the
declared shim target.
- Line 3: Before merging the faster-dooit manifest, add a linked package-request
issue to the PR description and provide evidence that the upstream project
satisfies the acceptance criteria, including the required GitHub popularity
threshold or explicit maintainer approval for an exception. If the repository is
unavailable or does not meet the threshold without approval, do not merge the
manifest.
---
Nitpick comments:
In `@bucket/faster-dooit.json`:
- Around line 17-23: Before submitting faster-dooit.json, run the required
manifest validation steps with checkver.ps1, formatjson.ps1, and a 64-bit scoop
install, then verify the file still uses CRLF line endings. Use the existing
autoupdate and hash entries in faster-dooit.json as the manifest under test, and
fix any version-detection, formatting, installation, or line-ending issues
surfaced by those checks before resubmitting.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 3889c885-5ac6-4c43-8582-1c259163cf1b
📒 Files selected for processing (1)
bucket/faster-dooit.json
| @@ -0,0 +1,24 @@ | |||
| { | |||
| "version": "0.1.0", | |||
| "description": "A vim-style TUI todo manager written in Go. Unaffiliated with the dooit project; AI-assisted, hobby project.", | |||
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟠 Major | 🏗️ Heavy lift
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "Changed/new files:"
git diff --name-only HEAD~1..HEAD 2>/dev/null || git diff --name-only 2>/dev/null || true
git status --short 2>/dev/null || true
echo
echo "Manifest candidate:"
if [ -f bucket/faster-dooit.json ]; then
wc -l bucket/faster-dooit.json
sed -n '1,220p' bucket/faster-dooit.json | cat -A
else
echo "bucket/faster-dooit.json not found"
fiRepository: ScoopInstaller/Extras
Length of output: 1928
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "Repository metadata check via GitHub:"
for repo in XiaTian-AC/faster-dooit ScoopInstaller/Extras; do
echo "--- $repo ---"
gh repo view "$repo" --json starredCount,forkCount,source,description --jq '{repo: .nameWithOwner, description: .description, stars: .stargazerCount, forks: .forkCount, isSource: .source.repository.nameWithOwner}' 2>/dev/null || true
done
echo
echo "Package request references in repo/PR-like context:"
rg -n --hidden --glob '!*.lock' 'package-request|faster-dooit|#\d+\s*[:\)]|XiaTian-AC/faster-dooit' . 2>/dev/null | head -200 || trueRepository: ScoopInstaller/Extras
Length of output: 1928
🌐 Web query:
ScoopInstaller Extras package request acceptance criteria 100 stars 50 forks
💡 Result:
For a package to be accepted into the ScoopInstaller Extras bucket, it is required to be "reasonably well-known and widely used" [1][2]. As a specific indicator of this popularity, the project generally requires the application to have at least 100 stars and/or 50 forks if it is a GitHub-hosted project [1][2]. This criterion is part of a broader set of requirements that contributors should verify when creating a package request issue [2]: 1. Reasonably well-known and widely used (e.g., at least 100 stars and/or 50 forks for GitHub projects) [1][2]. 2. English interface (or at least English documentation) [1][2]. 3. Latest stable version [1][2]. 4. Full version (not a trial version) [1][2]. 5. Fairly standard install process (e.g., uses a version-specific download URL, without elaborate pre/post-install scripts) [1][2]. Contributors are encouraged to initiate the process by opening a package request issue using the standard template provided in the Extras repository, which helps maintainers assess whether the software meets these criteria [2].
Citations:
🌐 Web query:
XiaTian-AC/faster-dooit stars forks
💡 Result:
There is no repository named XiaTian-AC/faster-dooit on GitHub. Research indicates that the search query likely confuses several distinct projects and entities: 1. Dooit: The most prominent project with this name is the TUI (Terminal User Interface) todo manager hosted at dooit-org/dooit [1][2]. It is a popular Python-based application with over 2,900 stars and more than 120 forks [3][2]. 2. FASTER: This name appears in various technical contexts, such as a research paper regarding "Fast Action Sampling for Immediate Reaction" (FASTER) [4], a reinforcement learning project [5], and a vision transformer model (FasterViT) [6]. 3. Entity names: "XiaTian" is a name that appears in various contexts, including academic researchers (e.g., Xiatian Zhu) [7][8], a character in the beatmania IIDX game series [9], and a manufacturing company (Cixi Xiatian Electrical Appliances Co., Ltd.) [10][11]. No evidence was found linking these specific terms to a repository named "faster-dooit" under the user "XiaTian-AC."
Citations:
- 1: https://www.github.com/dooit-org/dooit
- 2: https://github.com/kraanzu/dooit/
- 3: https://github.com/dooit-org
- 4: https://github.com/innovator-zero/FASTER/blob/main/README.md
- 5: https://arxiv.org/html/2604.19730v1
- 6: https://proceedings.iclr.cc/paper_files/paper/2024/file/7e49642375e3315467fa33120813547f-Paper-Conference.pdf
- 7: https://mlanthology.org/authors/z/zhu-xiatian/
- 8: http://news.swjtu.edu.cn/info/1019/78365.htm
- 9: https://remywiki.com/Xiatian
- 10: https://www.chinaxiongwei.com/product/circulator-and-fan/aircirculator-fan/
- 11: https://airpurifier.en.made-in-china.com/
Provide valid package-request evidence before merging.
As a new Extras manifest, this needs a linked package-request issue in the PR description and evidence that the package meets the acceptance criteria. GitHub-hosted packages generally require at least 100 stars and/or 50 forks for project repute, unless maintainer approval is obtained for an exception. If the upstream repository is unavailable or fails to meet this bar, the manifest should not be merged.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@bucket/faster-dooit.json` at line 3, Before merging the faster-dooit
manifest, add a linked package-request issue to the PR description and provide
evidence that the upstream project satisfies the acceptance criteria, including
the required GitHub popularity threshold or explicit maintainer approval for an
exception. If the repository is unavailable or does not meet the threshold
without approval, do not merge the manifest.
Sources: Path instructions, Learnings, MCP tools
|
Thanks for the review! I've pushed fixes addressing the code issues:
Regarding the popularity gate (100+ stars / 50+ forks for GitHub-hosted packages): I understand the community requirement. This is a small hobby project by a middle-school student developer — it's actively developed and installs cleanly via the personal bucket ( Either way, thank you for the thorough review. |
|
To add a new package to this bucket, please follow the standard way to create a package request issue first and link it to your PR. When creating a package request, you can check the criteria for a package to be accepted in this bucket, which can help you determine whether your PR is likely to be approved. The information provided in the issue can also help maintainers quickly get the necessary details.
|
|
It appears that this package doesn't fully meet the essential criteria. Please feel free to reopen this PR once it fully meets the criteria, or consider creating your own bucket instead. |
2 participants
Add faster-dooit 0.1.0.
AI-assisted hobby project by a middle-school student developer.