Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/Tizen.NUI/src/internal/Application/NUICoreBackend.cs
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,7 @@ public void Run(string[] args)
Tizen.Tracer.End();

Tizen.Tracer.Begin("[NUI] NUICorebackend Run(): args of main set, window type set");
Tizen.Log.Info("NUI", "NUICoreBackend.Run(): begin to set main arguments");

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The log message explicitly includes the class and method name (NUICoreBackend.Run(): ). However, Tizen.Log.Info automatically captures and prints the caller's file name, member name, and line number using [CallerFilePath] and [CallerMemberName] attributes. Including this prefix manually is redundant and leads to duplicated information in the log output.\n\nAdditionally, for consistency with the rest of this file, you should use Log.Info directly instead of the fully qualified Tizen.Log.Info.

            Log.Info("NUI", "begin to set main arguments");

if (Tizen.Applications.Application.Current?.ApplicationInfo != null)
{
args[0] = Tizen.Applications.Application.Current.ApplicationInfo.ExecutablePath;
Expand All @@ -198,6 +199,7 @@ public void Run(string[] args)
args[0] = this.GetType().Assembly.FullName.Replace(" ", "");
}

Tizen.Log.Info("NUI", "NUICoreBackend.Run(): main arguments set, begin to create application");

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The log message explicitly includes the class and method name (NUICoreBackend.Run(): ). However, Tizen.Log.Info automatically captures and prints the caller's file name, member name, and line number using [CallerFilePath] and [CallerMemberName] attributes. Including this prefix manually is redundant and leads to duplicated information in the log output.\n\nAdditionally, for consistency with the rest of this file, you should use Log.Info directly instead of the fully qualified Tizen.Log.Info.

            Log.Info("NUI", "main arguments set, begin to create application");

if (windowData != null)
{
bool enableUIThread = coreTask != null;
Expand Down Expand Up @@ -236,6 +238,7 @@ public void Run(string[] args)
}
}
}
Tizen.Log.Info("NUI", "NUICoreBackend.Run(): application created");

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The log message explicitly includes the class and method name (NUICoreBackend.Run(): ). However, Tizen.Log.Info automatically captures and prints the caller's file name, member name, and line number using [CallerFilePath] and [CallerMemberName] attributes. Including this prefix manually is redundant and leads to duplicated information in the log output.\n\nAdditionally, for consistency with the rest of this file, you should use Log.Info directly instead of the fully qualified Tizen.Log.Info.

            Log.Info("NUI", "application created");

Tizen.Tracer.End();

Tizen.Tracer.Begin("[NUI] NUICorebackend Run(): add application related events");
Expand Down
Loading