Skip to content

[NUI] Add diagnostic logs for application initialization delay - #7766

Open
tscholb wants to merge 1 commit into
Samsung:API13from
tscholb:260721_API13
Open

[NUI] Add diagnostic logs for application initialization delay#7766
tscholb wants to merge 1 commit into
Samsung:API13from
tscholb:260721_API13

Conversation

@tscholb

@tscholb tscholb commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Description of Change

API Changes

  • ACR:

@github-actions github-actions Bot added the API13 Platform : Tizen 10.0 / TFM: net8.0-tizen10.0 label Jul 21, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds informational logging statements to track the execution progress of the NUICoreBackend.Run() method. The review feedback suggests removing the redundant class and method name prefixes from the log messages, as Tizen.Log.Info automatically captures caller details. Additionally, it is recommended to use Log.Info directly instead of the fully qualified Tizen.Log.Info to maintain consistency with the rest of the file.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Tizen.Tracer.End();

Tizen.Tracer.Begin("[NUI] NUICorebackend Run(): args of main set, window type set");
Tizen.Log.Info("NUI", "NUICoreBackend.Run(): begin to set main arguments");

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The log message explicitly includes the class and method name (NUICoreBackend.Run(): ). However, Tizen.Log.Info automatically captures and prints the caller's file name, member name, and line number using [CallerFilePath] and [CallerMemberName] attributes. Including this prefix manually is redundant and leads to duplicated information in the log output.\n\nAdditionally, for consistency with the rest of this file, you should use Log.Info directly instead of the fully qualified Tizen.Log.Info.

            Log.Info("NUI", "begin to set main arguments");

args[0] = this.GetType().Assembly.FullName.Replace(" ", "");
}

Tizen.Log.Info("NUI", "NUICoreBackend.Run(): main arguments set, begin to create application");

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The log message explicitly includes the class and method name (NUICoreBackend.Run(): ). However, Tizen.Log.Info automatically captures and prints the caller's file name, member name, and line number using [CallerFilePath] and [CallerMemberName] attributes. Including this prefix manually is redundant and leads to duplicated information in the log output.\n\nAdditionally, for consistency with the rest of this file, you should use Log.Info directly instead of the fully qualified Tizen.Log.Info.

            Log.Info("NUI", "main arguments set, begin to create application");

}
}
}
Tizen.Log.Info("NUI", "NUICoreBackend.Run(): application created");

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The log message explicitly includes the class and method name (NUICoreBackend.Run(): ). However, Tizen.Log.Info automatically captures and prints the caller's file name, member name, and line number using [CallerFilePath] and [CallerMemberName] attributes. Including this prefix manually is redundant and leads to duplicated information in the log output.\n\nAdditionally, for consistency with the rest of this file, you should use Log.Info directly instead of the fully qualified Tizen.Log.Info.

            Log.Info("NUI", "application created");

@JoonghyunCho

Copy link
Copy Markdown
Member

🤖 [AI Review]

Reviewed — no findings.

Scope checked:

  • Change is limited to three Tizen.Log.Info("NUI", ...) diagnostic statements inside the existing public void Run(string[] args) body — signature unchanged, so no public-API / XML-doc impact.
  • NUICoreBackend lives under src/internal/, and the log tag/level ("NUI", Info) is consistent with the surrounding Tizen.Tracer.Begin/End instrumentation.
  • Logs sit on the one-time application startup path (not inside a loop), so no allocation or hot-path perf concern.

No 🔴 critical issues, no 🟡 suggestions to flag.


Automated review — final merge decision rests with human reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API13 Platform : Tizen 10.0 / TFM: net8.0-tizen10.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants