Skip to content

test: server-only-modules e2e -> reset qwik duplicate-import guard between in-process vite servers #8722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maiieul merged 1 commit into from
Jun 18, 2026
Merged

test: server-only-modules e2e -> reset qwik duplicate-import guard between in-process vite servers #8722

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions e2e/qwik-e2e/tests/server-only-modules.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,12 @@ test.describe('server-only modules', () => {

test.skip(({ browserName }) => browserName !== 'chromium', 'Runs once in Chromium e2e.');

test.beforeEach(() => {

@maiieul maiieul Jun 11, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once merged, we should rebase #8609 and remove it in there for cleanup.

// Core's duplicate-import guard (Q30) lives on globalThis and survives
// server.close(); reset it so each in-process Vite server can re-evaluate core.
(globalThis as any).__qwik = undefined;
});

test('allows .server imports used only by routeLoader$', async () => {
try {
await cleanBuildOutput(allowedAppDir);
Expand Down
Loading