test: server-only-modules e2e -> reset qwik duplicate-import guard between in-process vite servers - #8722
Merged
Conversation
|
@qwik.dev/core
@qwik.dev/router
eslint-plugin-qwik
create-qwik
@qwik.dev/optimizer
commit: |
maiieul
commented
Jun 11, 2026
|
|
||
| test.skip(({ browserName }) => browserName !== 'chromium', 'Runs once in Chromium e2e.'); | ||
|
|
||
| test.beforeEach(() => { |
Member
Author
There was a problem hiding this comment.
Once merged, we should rebase #8609 and remove it in there for cleanup.
maiieul
changed the title
Varixo
approved these changes
Jun 18, 2026
github-project-automation
Bot
moved this from Waiting For Review
to Done
in Qwik Development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description
The server-only-modules e2e spec creates multiple in-process Vite dev servers, and core's duplicate-import guard (
globalThis.__qwik) survivesserver.close(), so the next server's module runner threw Q30 — "dev ssr mode allows server-only imports used only by routeLoader$" failed when run after the development-mode test. Reset the guard in abeforeEach. Only visible with--retries=0since a retry re-runs the serial group in a fresh worker.