fix(client): declare typing-extensions dependency for openpi-client#996
Open
Bartok9 wants to merge 1 commit into
Open
fix(client): declare typing-extensions dependency for openpi-client#996Bartok9 wants to merge 1 commit into
Bartok9 wants to merge 1 commit into
Conversation
Salvage of Physical-Intelligence#866 by @adamheins — rebased to main. openpi_client imports typing_extensions.override but packages/openpi-client pyproject.toml omitted the dependency (main currently has dm-tree already).
Bartok9
requested review from
Michael-Equi,
jimmyt857 and
kvablack
as code owners
July 11, 2026 00:00
jimmyt857
removed their request for review
July 11, 2026 19:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
typing-extensions>=4.12.2topackages/openpi-clientdependencies.Motivation
openpi_clientimportstyping_extensions.overridein multiple modules. The subpackagepyproject.tomldid not declare that dependency.Salvage of #866 by @adamheins — rebased to current
main(that PR is conflicting / listed an outdatedtreedep line).Verification
from typing_extensions import overridein openpi-client sourcesdm-tree(separate from Correct dep to dm-tree #803); this only adds typing-extensionsAttribution
Salvage of #866 by @adamheins — rebased to main