Skip to content

Clean-up and organize test fixtures and cases for EntryConvert - #1588

Merged
dbeuchler merged 3 commits into
devfrom
fix/entry-convert-tests
Nov 6, 2026
Merged

dbeuchler merged 3 commits into
devfrom
fix/entry-convert-tests

Conversation

@1nf0rmagician

@1nf0rmagician 1nf0rmagician commented Nov 3, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Split type-conversion , ossible-values realted and pure Entry tests from general entry convert tests
  • Move method related validation tests to validation tests
  • Merge possible values and allowed/denied value tests
  • Merge EntryConvertTests and SerializationTests
  • Remove duplicated tests for clone, method parameter validation
  • Merge different static SubEntry methods, add a static method to create a sub-entry from prototype
  • Statically create possible values serialization
  • Merge some dummy classes into the ClassDummy
  • Apply one type per file for dummies as well
  • Move all dummies into a subfolder
  • Align names for dummies in this namespace
  • Replace index-based test arrange and assert with identifier based access
  • Add test fixture comments to draw attention to the fact that there exist multiple test fixtures for testing EntryConvert
  • Move missplaced EntrySerializeSerialization test cases into their test fixutre
  • Group all EntryConvert tests in a directory
  • Align mixed method name convention in NumericEntryConverterTests
  • Fix naming violations in EntrySerializeSerializationDummies
  • Fix missing renames of 'converter' to 'encoder'

Linked Issues

Builds up #1587

Checklist for Submitter

  • I have tested these changes locally
  • I have updated documentation as needed
  • I have added or updated tests as appropriate
  • I have used clear and descriptive commit messages

Review

Typical tasks

  • Merge request is well described
  • Critical sections are documented in code
  • Tests are extended
  • Documentation is created / updated
  • Running in test environment
  • Ports to other maintained versions are created

Clean code

  • All unused references are removed
  • Clean code rules are respected with passion (naming, ...)
  • Avoid copy and pasted code snippets

@1nf0rmagician 1nf0rmagician self-assigned this Nov 3, 2026
@1nf0rmagician 1nf0rmagician added the enhancement New feature or request label Nov 3, 2026
@1nf0rmagician 1nf0rmagician added this to the Framework 10.x milestone Nov 3, 2026
- Split type-conversion , ossible-values realted and pure `Entry` tests from general entry convert tests
- Move method related validation tests to validation tests
- Merge possible values and allowed/denied value tests
- Merge `EntryConvertTests` and `SerializationTests`
- Remove duplicated tests for clone, method parameter validation
- Merge different static SubEntry methods, add a static method to create a sub-entry from prototype
- Statically create possible values serialization
- Merge some dummy classes into the `ClassDummy`
- Apply one type per file for dummies as well
- Move all dummies into a subfolder
- Align names for dummies in this namespace
- Replace index-based test arrange and assert with identifier based access
- Add test fixture comments to draw attention to the fact that there exist multiple test fixtures for testing `EntryConvert`
- Move missplaced `EntrySerializeSerialization` test cases into their test fixutre
- Group all `EntryConvert` tests in a directory
- Align mixed method name convention in NumericEntryConverterTests
- Fix naming violations in `EntrySerializeSerializationDummies`
- Fix missing renames from 'converter' to 'encoder'
@1nf0rmagician
1nf0rmagician force-pushed the fix/entry-convert-tests branch from b25f23b to 350837c Compare November 6, 2026 06:11
@1nf0rmagician
1nf0rmagician marked this pull request as ready for review November 6, 2026 06:15
@codecov

codecov Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.17%. Comparing base (6e4f4b0) to head (d51d81d).
⚠️ Report is 15 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1588      +/-   ##
==========================================
+ Coverage   56.14%   56.17%   +0.02%     
==========================================
  Files         985      985              
  Lines       34659    34660       +1     
  Branches     3523     3524       +1     
==========================================
+ Hits        19459    19469      +10     
+ Misses      14245    14229      -16     
- Partials      955      962       +7     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dbeuchler
dbeuchler force-pushed the fix/entry-convert-tests branch from c8d9028 to d51d81d Compare November 6, 2026 11:08

@dbeuchler dbeuchler left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A general thing: could you keep the test names? We kept it optional which naming pattern we use and we should not change existing test names to an other preference: In this case: EncodesStructWithSubEntries. Maybe we should adjust the guideline a bit to keep it consistens in a fixture. But it is not in it now and we should respect that. Regarding your offline-time I changed it for 3 tests and also applied some code cleanup approved by @andreniggemann on call.

@dbeuchler
dbeuchler merged commit 6a062bc into dev Nov 6, 2026
9 checks passed
@dbeuchler
dbeuchler deleted the fix/entry-convert-tests branch November 6, 2026 11:24
@1nf0rmagician

Copy link
Copy Markdown
Member Author

Thanks for finishing this for me during my absence @dbeuchler and @andreniggemann!

A general thing: could you keep the test names? We kept it optional which naming pattern we use and we should not change existing test names to an other preference: In this case: EncodesStructWithSubEntries.

I did not intend to upset anyone/anything, sorry for that. I apparently had a slightly different understanding of the intent in our writing tests guidelin. If at any point this becomes relevant again, I'll initiate a discussion before changing anything ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants