Repository navigation
Clean-up and organize test fixtures and cases for EntryConvert - #1588
Conversation
- Split type-conversion , ossible-values realted and pure `Entry` tests from general entry convert tests - Move method related validation tests to validation tests - Merge possible values and allowed/denied value tests - Merge `EntryConvertTests` and `SerializationTests` - Remove duplicated tests for clone, method parameter validation - Merge different static SubEntry methods, add a static method to create a sub-entry from prototype - Statically create possible values serialization - Merge some dummy classes into the `ClassDummy` - Apply one type per file for dummies as well - Move all dummies into a subfolder - Align names for dummies in this namespace - Replace index-based test arrange and assert with identifier based access - Add test fixture comments to draw attention to the fact that there exist multiple test fixtures for testing `EntryConvert` - Move missplaced `EntrySerializeSerialization` test cases into their test fixutre - Group all `EntryConvert` tests in a directory - Align mixed method name convention in NumericEntryConverterTests - Fix naming violations in `EntrySerializeSerializationDummies` - Fix missing renames from 'converter' to 'encoder'
b25f23b to
350837c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1588 +/- ##
==========================================
+ Coverage 56.14% 56.17% +0.02%
==========================================
Files 985 985
Lines 34659 34660 +1
Branches 3523 3524 +1
==========================================
+ Hits 19459 19469 +10
+ Misses 14245 14229 -16
- Partials 955 962 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-authored-by: claude:opus-5.5
c8d9028 to
d51d81d
Compare
dbeuchler
left a comment
There was a problem hiding this comment.
A general thing: could you keep the test names? We kept it optional which naming pattern we use and we should not change existing test names to an other preference: In this case: EncodesStructWithSubEntries. Maybe we should adjust the guideline a bit to keep it consistens in a fixture. But it is not in it now and we should respect that. Regarding your offline-time I changed it for 3 tests and also applied some code cleanup approved by @andreniggemann on call.
|
Thanks for finishing this for me during my absence @dbeuchler and @andreniggemann!
I did not intend to upset anyone/anything, sorry for that. I apparently had a slightly different understanding of the intent in our writing tests guidelin. If at any point this becomes relevant again, I'll initiate a discussion before changing anything |
Summary
Entrytests from general entry convert testsEntryConvertTestsandSerializationTestsClassDummyEntryConvertEntrySerializeSerializationtest cases into their test fixutreEntryConverttests in a directoryEntrySerializeSerializationDummiesLinked Issues
Builds up #1587
Checklist for Submitter
Review
Typical tasks
Clean code