Skip to content

Do not override DisplayName and Description for structs - #1596

Merged
dbeuchler merged 1 commit into
devfrom
improve/display-name-encoded-structs
Nov 6, 2026
Merged

dbeuchler merged 1 commit into
devfrom
improve/display-name-encoded-structs

Conversation

@dbeuchler

Copy link
Copy Markdown
Member

DisplayName and descriptions were always taken from the member instead of the encoder. Now it is optional and when the encoder sets the value, it will be taken.

For numeric structs, we concat by the sub-entries + value.

Screenshot 2026-11-06 at 11 05 04

No new tests added, will follow when #1588 is merged

@dbeuchler dbeuchler added this to the Framework 10.x milestone Nov 6, 2026
@dbeuchler dbeuchler self-assigned this Nov 6, 2026
@dbeuchler dbeuchler added the enhancement New feature or request label Nov 6, 2026
@dbeuchler
dbeuchler merged commit 5ad935a into dev Nov 6, 2026
12 of 13 checks passed
@dbeuchler
dbeuchler deleted the improve/display-name-encoded-structs branch November 6, 2026 11:18
@codecov

codecov Bot commented Nov 6, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 56.14%. Comparing base (68cf3f4) to head (b3297c0).
⚠️ Report is 6 commits behind head on dev.

Files with missing lines Patch % Lines
...c/Moryx/Serialization/EntryConvert/EntryConvert.cs 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1596   +/-   ##
=======================================
  Coverage   56.13%   56.14%           
=======================================
  Files         985      985           
  Lines       34659    34664    +5     
  Branches     3523     3526    +3     
=======================================
+ Hits        19457    19462    +5     
+ Misses      14246    14245    -1     
- Partials      956      957    +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants