-
Notifications
You must be signed in to change notification settings - Fork 10
chore(deps)(deps-dev): bump three from 0.184.0 to 0.185.1 #2144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dependabot
wants to merge
1
commit into
main
Choose a base branch
from
dependabot/npm_and_yarn/three-0.185.1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Issue: Three.js runtime upgrade lacks visible render-path validation
What's wrong
This PR updates a user-facing rendering dependency in two packages, but the diff does not add any test or validation evidence for the paths most likely to break: Three.js-backed graph rendering and the node UI. Without a render smoke test or documented validation, the upgrade can be green while a runtime-only visualization regression ships.
Example
A regression in Three.js 0.185.1 that changes a renderer, geometry, material, or control API used by the graph visualization could still pass if CI only installs successfully. A useful check would render a minimal graph scene in
packages/graph-vizand load the node UI path that imports Three.js, then assert the scene initializes without runtime errors.Suggested direction
Add a focused smoke/regression test or include explicit validation evidence for the affected visualization paths, preferably covering real imports and initialization rather than only package resolution.
Confidence note
The diff only shows the dependency bump and lockfile update; I do not see accompanying tests or recorded validation evidence in the PR diff.
For Agents
Look at the Three.js usage in
packages/graph-vizandpackages/node-ui; add or document validation that exercises the real render initialization withthree@0.185.1. Preserve the dependency bump, but prove the graph visualization and node UI still mount/render under the new version.