chore(deps)(deps-dev): bump three from 0.184.0 to 0.185.1 - #2144
chore(deps)(deps-dev): bump three from 0.184.0 to 0.185.1#2144dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [three](https://github.com/mrdoob/three.js) from 0.184.0 to 0.185.1. - [Release notes](https://github.com/mrdoob/three.js/releases) - [Commits](https://github.com/mrdoob/three.js/commits) --- updated-dependencies: - dependency-name: three dependency-version: 0.185.1 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
| "@types/react": "^19.2.14", | ||
| "@vitest/coverage-v8": "^4.0.18", | ||
| "three": "^0.184.0", | ||
| "three": "^0.185.1", |
There was a problem hiding this comment.
🟡 Issue: Three.js runtime upgrade lacks visible render-path validation
What's wrong
This PR updates a user-facing rendering dependency in two packages, but the diff does not add any test or validation evidence for the paths most likely to break: Three.js-backed graph rendering and the node UI. Without a render smoke test or documented validation, the upgrade can be green while a runtime-only visualization regression ships.
Example
A regression in Three.js 0.185.1 that changes a renderer, geometry, material, or control API used by the graph visualization could still pass if CI only installs successfully. A useful check would render a minimal graph scene in packages/graph-viz and load the node UI path that imports Three.js, then assert the scene initializes without runtime errors.
Suggested direction
Add a focused smoke/regression test or include explicit validation evidence for the affected visualization paths, preferably covering real imports and initialization rather than only package resolution.
Confidence note
The diff only shows the dependency bump and lockfile update; I do not see accompanying tests or recorded validation evidence in the PR diff.
For Agents
Look at the Three.js usage in packages/graph-viz and packages/node-ui; add or document validation that exercises the real render initialization with three@0.185.1. Preserve the dependency bump, but prove the graph visualization and node UI still mount/render under the new version.
1 participant
Bumps three from 0.184.0 to 0.185.1.
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)