Skip to content

fix(nix): fix nix build with waveform support - #151

Merged
ngc7331 merged 3 commits into
masterfrom
fix-nix
Oct 30, 2026
Merged

fix(nix): fix nix build with waveform support#151
ngc7331 merged 3 commits into
masterfrom
fix-nix

Conversation

@ngc7331

@ngc7331 ngc7331 commented Oct 29, 2026

Copy link
Copy Markdown
Member
  • Makefile: make GSIM_INCLUDE_PATH overridable
  • nix: add missing zlib dependency
  • nix: set GSIM_INCLUDE_PATH to $out and install include to $out

Also:

  • add CI to check nix build

@ngc7331
fix(nix): add missing zlib dependency
fdf2d67 
Signed-off-by: ngc7331 <ngc7331@outlook.com>
@ngc7331
fix(Makefile,nix): make GSIM_INCLUDE_DIR overridable & install include
de58163 
Signed-off-by: ngc7331 <ngc7331@outlook.com>
@ngc7331
ci: add nix build test
7847334 
Signed-off-by: ngc7331 <ngc7331@outlook.com>
@ngc7331 ngc7331 mentioned this pull request Oct 29, 2026
Merged
eastonman
eastonman approved these changes Oct 30, 2026
View reviewed changes

@eastonman eastonman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ngc7331
ngc7331 merged commit 45a73d6 into master Oct 30, 2026
13 checks passed
@ngc7331
ngc7331 deleted the fix-nix branch October 30, 2026 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eastonman eastonman eastonman approved these changes
@Wolf-Tungsten Wolf-Tungsten Awaiting requested review from Wolf-Tungsten

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ngc7331 @eastonman