[16.0][FIX] shopfloor: handle invalid product error gracefully on lot scan - #1250
Open
nicolas-delbovier-acsone wants to merge 1 commit into
Conversation
When scanning a barcode containing both product and lot info for a product different from the current line, a `SearchInvalidProduct` exception was uncaught in `cluster_picking`, leading to an unhandled 500 internal server error in the Shopfloor application.
Contributor
sebalix
reviewed
Sep 1, 2026
jbaudoux
approved these changes
Sep 2, 2026
Contributor
|
/ocabot merge patch |
Contributor
|
Hey, thanks for contributing! Proceeding to merge this for you. |
lmignon
reviewed
Sep 2, 2026
Comment on lines
+505
to
+506
| lot = None | ||
| lot = search.lot_from_scan(barcode, products=move_line.product_id) |
Contributor
There was a problem hiding this comment.
No, it cannot. But would be maybe more understandable if outside try.
There was a problem hiding this comment.
If the variable is not initialized, the rest of the code will fail in case lot_from_scan raises an error.
lmignon
approved these changes
Sep 2, 2026
Contributor
|
This PR has the |
Contributor
|
@nicolas-delbovier-acsone needs rebase for merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When scanning a barcode containing both product and lot info for a product
different from the current line, a
SearchInvalidProductexception wasuncaught in
cluster_picking, leading to an unhandled 500 internal servererror in the Shopfloor application.
cc @jbaudoux