[16.0][REF] shopfloor: use msg_store instead of copy pasting messages - #1252
Open
nicolas-delbovier-acsone wants to merge 5 commits into
Open
[16.0][REF] shopfloor: use msg_store instead of copy pasting messages#1252nicolas-delbovier-acsone wants to merge 5 commits into
nicolas-delbovier-acsone wants to merge 5 commits into
Conversation
Refactor inline message dictionaries across services (checkout, cluster picking, location content transfer) and test cases to use dedicated helper methods on `self.msg_store`.
…y pasting messages
nicolas-delbovier-acsone
force-pushed
the
16.0-imp-shopfloor-use-msg-store-in-unit-tests
branch
from
September 3, 2026 09:25
6736376 to
ba77402
Compare
OCA-git-bot
added
series:16.0
mod:shopfloor
nicolas-delbovier-acsone
changed the title
…instead of copy pasting messages
…opy pasting messages
OCA-git-bot
added
mod:shopfloor_single_product_transfer
nicolas-delbovier-acsone
marked this pull request as ready for review
September 3, 2026 10:09
Author
|
@sebalix Here is the PR we were talking about here: #1250 (comment) |
sebalix
approved these changes
Sep 3, 2026
sebalix
left a comment
sebalix
left a comment
There was a problem hiding this comment.
Thank you! There were a lot of them... LG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There has been this bad practice for a while in Shopfloor unit tests to copy paste the expected messages instead of using the
msg_storeto call the message functions.This leads to a codebase that is less maintainable since changes in the wording now needs to be performed in multiple places (does not respect DRY principle).