Skip to content

[dev/gfs.v17] Cleanup some unused variables in v17 #5269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TravisElless-NOAA merged 11 commits into from
Sep 28, 2026
Merged

[dev/gfs.v17] Cleanup some unused variables in v17 #5269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c6eefa8
remove unused config files
TravisElless-NOAA Sep 4, 2026
135d247
some additional cleanup
TravisElless-NOAA Sep 4, 2026
4920946
remove gcafs from fcst
TravisElless-NOAA Sep 4, 2026
637790e
add back fix directories
TravisElless-NOAA Sep 8, 2026
f88540b
move component fix
TravisElless-NOAA Sep 8, 2026
eeab528
global variables need to be in config.base
TravisElless-NOAA Sep 8, 2026
9146d6d
Merge remote-tracking branch 'origin/dev/gfs.v17' into mait/v17_confi…
TravisElless-NOAA Sep 8, 2026
39b8a52
remove local aero variables
TravisElless-NOAA Sep 8, 2026
bb2958e
final cleanup
TravisElless-NOAA Sep 8, 2026
acd3c9b
fix spacing
TravisElless-NOAA Sep 8, 2026
06bca8c
Add archive control variables to aux.xml.j2
DavidHuber-NOAA Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dev/jobs/JGLOBAL_ATMOS_TROPCY_QC
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ source "${USHglobal}/set_strict.sh"
export PROCESS_TROPCY=${PROCESS_TROPCY:-YES} # Turn on tropical cyclone tcvitals QC proc. if YES

export tmmark=tm00
export COMINsyn=${COMINsyn:-$(compath.py "${envir}/com/gfs/${gfs_ver}")/syndat}
export ARCHSYND=${ROTDIR}/syndat # this location is unique, do not change
mkdir -p "${ARCHSYND}"

Expand Down
14 changes: 1 addition & 13 deletions dev/jobs/JGLOBAL_FCST
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,13 +78,7 @@ declare -rx COMOUT_ATMOS_RESTART="${COMOUT}/model/atmos/restart"
declare -rx COMOUT_ATMOS_HISTORY="${COMOUT}/model/atmos/history"
declare -rx COMOUT_ATMOS_MASTER="${COMOUT}/model/atmos/master"

# GCAFS/GCDAS uses an offline atmospheric analysis
if [[ "${RUN}" =~ "gcafs" ]] || [[ "${RUN}" =~ "gcdas" ]]; then
declare -rx COMIN_ATMOS_ANALYSIS="${COMIN_RESTART}/analysis/atmos"
else
# other runs use their own atmospheric analysis
declare -rx COMIN_ATMOS_ANALYSIS="${COMIN}/analysis/atmos"
fi
declare -rx COMIN_ATMOS_ANALYSIS="${COMIN}/analysis/atmos"

if [[ "${DO_WAVE}" == "YES" ]]; then
declare -rx COMIN_WAVE_INIT="${COMIN}/model/wave/init"
Expand All @@ -109,12 +103,6 @@ if [[ "${DO_ICE}" == "YES" ]]; then
declare -rx COMIN_ICE_RESTART_PREV="${COMIN_RESTART_PREV}/model/ice/restart"
fi

if [[ "${DO_AERO_FCST}" == "YES" ]]; then
declare -rx COMOUT_CHEM_HISTORY="${COMOUT}/model/chem/history"
declare -rx COMIN_TRACER_RESTART="${COMIN_RESTART}/model/atmos/restart"
declare -rx COMIN_CHEM_INPUT="${COMIN}/model/chem/input"
fi

###############################################################
# Run relevant exglobal script
###############################################################
Expand Down
23 changes: 5 additions & 18 deletions dev/ush/setup_gfs_for_nco.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,6 @@
# which J-Jobs to copy to jobs/. Then look for the associated ex-scripts called in the
# J-Jobs and copy those to scripts/ with appropriate renaming.
base_job_list = [
"JGLOBAL_ANALYSIS_STATS",
"JGLOBAL_ARCHIVE_TARS",
"JGLOBAL_ARCHIVE_VRFY",
"JGLOBAL_ATMOS_ANAL",
"JGLOBAL_ATMOS_ANAL_CALC",
"JGLOBAL_ATMOS_ANAL_DIAG",
Expand All @@ -39,8 +36,6 @@
"JGLOBAL_ATMOS_TROPCY_QC",
"JGLOBAL_ATMOS_UPP",
"JGLOBAL_ATMOS_VMINMON",
"JGLOBAL_CLEANUP",
"JGLOBAL_FETCH",
"JGLOBAL_FCST_FSM",
"JGLOBAL_FCST",
"JGLOBAL_FCST_MANAGER",
Expand Down Expand Up @@ -73,19 +68,13 @@
"JENKFGDAS_ENS_POST",
"JGDAS_FIT2OBS",
"JGFS_ATMOS_AWIPS_20KM_1P0",
"JGFS_ATMOS_CYCLONE_GENESIS",
"JGFS_ATMOS_CYCLONE_TRACKER",
"JGFS_ATMOS_FBWIND",
"JGFS_ATMOS_FSU_GENESIS",
"JGFS_ATMOS_GEMPAK",
"JGFS_ATMOS_GEMPAK_META",
"JGFS_ATMOS_GEMPAK_NCDC_UPAPGIF",
"JGFS_ATMOS_GEMPAK_PGRB2_SPEC",
"JGFS_ATMOS_GEMPAK_PGRB2_SPEC_NPOESS",
"JGFS_ATMOS_POST_SND",
"JGFS_ATMOS_VERIFICATION",
"JGLOBAL_ENKF_ARCHIVE_TARS",
"JGLOBAL_ENKF_ARCHIVE_VRFY",
"JGLOBAL_ATMOS_ENS_DIAG",
"JGLOBAL_ATMOS_ENS_RECENTER",
"JGLOBAL_ATMOS_ENS_OBSERVER",
Expand Down Expand Up @@ -116,9 +105,6 @@
"exglobal_wave_post_pnt.sh",
"exgfs_wave_awips_bulls.sh",
"exgfs_wave_awips_gridded.sh",
"exglobal_analysis_stats.py",
"exglobal_archive_tars.py",
"exglobal_archive_vrfy.py",
"exglobal_atmos_anal.sh",
"exglobal_atmos_anal_calc.sh",
"exglobal_atmos_products.sh",
Expand All @@ -127,9 +113,7 @@
"exglobal_atmos_tropcy_qc.sh",
"exglobal_atmos_upp.py",
"exglobal_atmos_vminmon.sh",
"exglobal_cleanup.sh",
"exglobal_atmos_diag.sh",
"exglobal_fetch.py",
"exglobal_fcst_fsm.sh",
"exglobal_fcst.sh",
"exglobal_fcst_manager.sh",
Expand All @@ -146,13 +130,16 @@
"exglobal_prep_sfc.sh",
"exglobal_snow_anal.py",
"exglobal_snow_ens_anal.py",
"exglobal_enkf_earc_tars.py",
"exglobal_enkf_earc_vrfy.py",
"exglobal_atmos_ens_recenter.sh",
"exglobal_atmos_ens_observer.sh",
"exglobal_atmos_ens_anal_sfc_gcycle.sh",
"exglobal_atmos_ens_anal_sfc_regrid.sh",
"exglobal_atmos_ens_update.sh",
# These scripts are needed for development aux workflow and not production
"exglobal_enkf_earc_tars.py",
"exglobal_enkf_earc_vrfy.py",
"exglobal_archive_tars.py",
"exglobal_archive_vrfy.py",
]

# If needed, add scripts and jobs that need to be renamed when copied.
Expand Down
13 changes: 11 additions & 2 deletions dev/workflow/aux/aux.xml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,9 @@
<envar><name>ARCH_LOGS</name><value>NO</value></envar>
<envar><name>SDATE</name><value>&SDATE;</value></envar>
<envar><name>EDATE</name><value>&EDATE;</value></envar>
<envar><name>DO_VMINMON</name><value>YES</value></envar>
<envar><name>DO_VERFRAD</name><value>YES</value></envar>
<envar><name>DO_VERFOZN</name><value>YES</value></envar>


<dependency>
Expand Down Expand Up @@ -406,6 +409,9 @@
<envar><name>DO_ANLSTAT</name><value>NO</value></envar>
<envar><name>SDATE</name><value>&SDATE;</value></envar>
<envar><name>EDATE</name><value>&EDATE;</value></envar>
<envar><name>DO_VMINMON</name><value>YES</value></envar>
<envar><name>DO_VERFRAD</name><value>YES</value></envar>
<envar><name>DO_VERFOZN</name><value>YES</value></envar>

<dependency>
<and>
Expand Down Expand Up @@ -447,7 +453,7 @@

<dependency>
<and>
<datadep><cyclestr offset="12:00:00">&ECF_OUT_gfs;/@Y@m@d@H</cyclestr></datadep>
<datadep><cyclestr offset="12:00:00">&ECF_OUT_gfs;/@Y@m@d@H</cyclestr></datadep>
</and>
</dependency>

Expand Down Expand Up @@ -480,6 +486,9 @@
<envar><name>ATARDIR</name><value>&ATARDIR;</value></envar>
<envar><name>ARCHCOM_TO</name><value>hpss</value></envar>
<envar><name>PSLOT</name><value>&PSLOT;</value></envar>
<envar><name>DO_VMINMON</name><value>YES</value></envar>
<envar><name>DO_VERFRAD</name><value>YES</value></envar>
<envar><name>DO_VERFOZN</name><value>YES</value></envar>

<dependency>
<datadep><cyclestr offset="12:00:00">&ECF_OUT_gfs;/@Y@m@d@H</cyclestr></datadep>
Expand Down Expand Up @@ -524,7 +533,7 @@
<envar><name>EDATE</name><value>&EDATE;</value></envar>

<dependency>
<datadep><cyclestr offset="12:00:00">&ECF_OUT_gfs;/@Y@m@d@H</cyclestr></datadep>
<datadep><cyclestr offset="12:00:00">&ECF_OUT_gfs;/@Y@m@d@H</cyclestr></datadep>
</dependency>

</task>
Expand Down
25 changes: 0 additions & 25 deletions parm/config/gfs/config.analcalc_fv3jedi
View file
Open in desktop

This file was deleted.

14 changes: 0 additions & 14 deletions parm/config/gfs/config.anlstat
View file
Open in desktop

This file was deleted.

89 changes: 6 additions & 83 deletions parm/config/gfs/config.base
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export machine="WCOSS2"
# Do not run strict mode (set -e) for production
export STRICT="NO"

# Directories relative to installation areas:
# Global directory paths
export EXECglobal="${HOMEglobal}/exec"
export FIXglobal="${HOMEglobal}/fix"
export PARMglobal="${HOMEglobal}/parm"
Expand All @@ -27,46 +27,17 @@ export FIXmom="${FIXglobal}/mom6"
export FIXreg2grb2="${FIXglobal}/reg2grb2"
export FIXgdas="${FIXglobal}/gdas"

########################################################################

# GLOBAL static environment parameters
export PACKAGEROOT="${PACKAGEROOT:-"/lfs/h1/ops/prod/packages"}" # TODO: set via prod_envir in Ops
export COMINsyn="/lfs/h1/ops/prod/com/gfs/v16.3/syndat"
export USE_IODADIR="NO"
ROTDIR=$(compath.py "${envir}/${NET}/${gfs_ver}")
export ROTDIR
export COMROOT=${ROTDIR}

# Toggle to turn on/off EMCSFC_SFC_PREP job
export DO_PREP_SFC="NO" # SNOGRB dump file production

# Toggle to turn on/off GFS downstream processing.
export DO_GOES="YES" # GOES products
# This block might be needed for development archiving but not for production
export DO_BUFRSND="YES" # BUFR sounding products
export DO_GEMPAK="YES" # GEMPAK products
export DO_AWIPS="NO" # AWIPS products
export DO_NPOESS="NO" # NPOESS products
export DO_TRACKER="YES" # Hurricane track verification
export DO_GENESIS="YES" # Cyclone genesis verification
export DO_GENESIS_FSU="NO" # Cyclone genesis verification (FSU)
export DO_VERFOZN="YES" # Ozone data assimilation monitoring
Comment thread
TravisElless-NOAA marked this conversation as resolved.
export DO_VERFRAD="YES" # Radiance data assimilation monitoring
export DO_VMINMON="YES" # GSI minimization monitoring

# Experiment mode (cycled or forecast-only)
export MODE="cycled" # cycled/forecast-only
export DO_TEST_MODE="NO" # option to change configuration for automated testing

####################################################
# DO NOT ADD MACHINE DEPENDENT STUFF BELOW THIS LINE
# IF YOU HAVE TO MAKE MACHINE SPECIFIC CHANGES BELOW
# FEEL FREE TO MOVE THEM ABOVE THIS LINE TO KEEP IT
# CLEAR
####################################################
# Build paths relative to $HOMEglobal
export FIXgsi="${HOMEglobal}/fix/gsi"
export HOMEpost="${HOMEglobal}"
export HOMEobsproc="${BASE_GIT:-}/obsproc/v${obsproc_run_ver:-}"
export BASE_ENV="${HOMEglobal}/env"

# CONVENIENT utility scripts and other environment parameters
export NMV="mv"
Expand All @@ -81,9 +52,6 @@ export DEBUG_POSTSCRIPT="NO" # PBS only; sets debug=true
export CAT_MPMD_LOGS="NO" # Copy MPMD logs to the parent log. Useful for debugging.
export CHECK_DEAD_LINKS="NO" # Whether to check for dead links in DATA directories before execution

# Machine environment, jobs, and other utility scripts
export BASE_ENV="${HOMEglobal}/env"

# EXPERIMENT specific environment parameters
export EXP_WARM_START=".true."
export assim_freq=6
Expand Down Expand Up @@ -115,10 +83,7 @@ export DO_COUPLED="NO"
export DO_WAVE="NO"
export DO_OCN="NO"
export DO_ICE="NO"
DO_AERO="NO"
export DO_PREP_OBS_AERO="NO"
aero_fcst_runs="gdas" # When to run aerosol forecast: gdas, gfs, or both
aero_anl_runs="gdas gfs" # When to run aerosol analysis: gdas, gfs, or both
export DO_AERO_FCST="NO"
export DO_AERO_ANL="NO"
if [[ "${RUN}" == "gfs" ]] ; then
Expand All @@ -128,17 +93,9 @@ else
fi

export FRAC_GRID=".true."
export DO_NEST="NO" # Whether to run a global-nested domain
if [[ "${DO_NEST:-NO}" == "YES" ]] ; then
export ntiles=7
export NEST_OUTPUT_GRID="regional_latlon"
export FIXugwd="${FIXglobal}/ugwd_nest"
export FIXorog="${FIXglobal}/orog_nest"
else
export ntiles=6
export FIXugwd="${FIXglobal}/ugwd"
export FIXorog="${FIXglobal}/orog"
fi
export ntiles=6
export FIXugwd="${FIXglobal}/ugwd"
export FIXorog="${FIXglobal}/orog"

# Resolution specific parameters
export LEVS=128
Expand Down Expand Up @@ -172,9 +129,6 @@ esac
case "${APP}" in
ATM)
;;
ATMA)
DO_AERO="YES"
;;
ATMW)
export DO_COUPLED="YES"
export DO_WAVE="YES"
Expand All @@ -189,10 +143,6 @@ case "${APP}" in
export DO_OCN="YES"
export DO_ICE="YES"

if [[ "${APP}" =~ A$ ]]; then
DO_AERO="YES"
fi

if [[ "${APP}" =~ ^S2SW ]]; then
export DO_WAVE="YES"
fi
Expand All @@ -203,16 +153,6 @@ case "${APP}" in
;;
esac

# Aerosol forecasts and analyses may be RUN-dependent
if [[ "${DO_AERO}" == "YES" ]]; then
if [[ ${aero_anl_runs} =~ ${RUN} ]]; then
export DO_AERO_ANL="YES"
fi
if [[ ${aero_fcst_runs} =~ ${RUN} ]]; then
export DO_AERO_FCST="YES"
fi
fi

# Surface cycle update frequency
if [[ "${RUN}" =~ "gdas" ]] ; then
export FHCYC=1
Expand Down Expand Up @@ -423,27 +363,10 @@ fi
# Execute the postamble (disable for production)
export TRAP_POSTAMBLE=NO

# The monitor jobs are not yet supported for JEDIATMVAR.
if [[ "${DO_JEDIATMVAR}" = "YES" ]]; then
export DO_FIT2OBS="NO" # Run fit to observations package
export DO_VERFOZN="NO" # Ozone data assimilation monitoring
export DO_VERFRAD="NO" # Radiance data assimilation monitoring
export DO_VMINMON="NO" # GSI minimization monitoring
fi

# If starting ICs that are not at cycle hour
export OFFSET_START_HOUR=0

# Number of regional collectives to create soundings for
export NUM_SND_COLLECTIVES=${NUM_SND_COLLECTIVES:-9}

# Set JEDI atmospheric DA increment type
if [[ "${DO_JEDIATMVAR}" == "YES" ]]; then
if [[ "${DO_JEDIATMENS}" == "YES" ]]; then
export ATMINC_GRID="cubed_sphere_grid"
else
export ATMINC_GRID="gaussian"
fi
fi

echo "END: config.base"
Loading
Loading