Skip to content

[dev/gfs.v17] Cleanup some unused variables in v17 - #5269

Merged
TravisElless-NOAA merged 11 commits into
NOAA-EMC:dev/gfs.v17from
TravisElless-NOAA:mait/v17_config_cleanup
Sep 28, 2026
Merged

TravisElless-NOAA merged 11 commits into
NOAA-EMC:dev/gfs.v17from
TravisElless-NOAA:mait/v17_config_cleanup

Conversation

@TravisElless-NOAA

Copy link
Copy Markdown
Contributor

Description

This PR primarily cleans up some config files and variables that are not used by the v17 package. Some additional unused/duplicate variable cleanup occurs in a few additional scripts as well.

Refs #5136

Type of change

  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this change expected to change outputs (e.g. value changes to existing outputs, new files stored in COM, files removed from COM, filename changes, additions/subtractions to archives)? NO
  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO

How has this been tested?

12z ecflow cycle completed successfully

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

@github-actions

github-actions Bot commented Sep 8, 2026 •

Copy link
Copy Markdown

Bash code analysis

✅ shellcheck and shfmt found no issues.

View the analysis run

@emcbot emcbot added CI-Ursa-Ready **CM use only** PR is ready for CI testing on Ursa CI-Ursa-Building **Bot use only** CI testing is cloning/building on Ursa CI-Ursa-Running **Bot use only** CI testing on Ursa for this PR is in-progress CI-Ursa-Passed **Bot use only** CI testing on Ursa for this PR has completed successfully and removed CI-Ursa-Ready **CM use only** PR is ready for CI testing on Ursa CI-Ursa-Building **Bot use only** CI testing is cloning/building on Ursa CI-Ursa-Running **Bot use only** CI testing on Ursa for this PR is in-progress labels Sep 8, 2026
Comment thread parm/config/gfs/config.base
@TravisElless-NOAA
TravisElless-NOAA merged commit 5c33220 into NOAA-EMC:dev/gfs.v17 Sep 28, 2026
5 checks passed
@TravisElless-NOAA
TravisElless-NOAA deleted the mait/v17_config_cleanup branch October 19, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-Ursa-Passed **Bot use only** CI testing on Ursa for this PR has completed successfully

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants