Skip to content

fix: MUSD-1165 Inconsistency with asset names #33140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kureev merged 2 commits into from
Jul 11, 2026
Merged

fix: MUSD-1165 Inconsistency with asset names #33140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ecf9124
fix: display asset name instead of symbol on Earn on your crypto Mone…
Matt561 Jul 10, 2026
24eb3ee
fix: fall back to token symbol when name is empty in Money earn on yo…
Matt561 Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions app/components/UI/Money/Views/MoneyPotentialEarningsView/MoneyPotentialEarningsView.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,12 +307,12 @@ describe('MoneyPotentialEarningsView', () => {
it('renders ALL eligible tokens, not limited to 5', () => {
const { getByText } = renderWithProvider(<MoneyPotentialEarningsView />);

expect(getByText('USDC')).toBeOnTheScreen();
expect(getByText('USDT')).toBeOnTheScreen();
expect(getByText('DAI')).toBeOnTheScreen();
expect(getByText('WETH')).toBeOnTheScreen();
expect(getByText('LINK')).toBeOnTheScreen();
expect(getByText('UNI')).toBeOnTheScreen();
expect(getByText('USD Coin')).toBeOnTheScreen();
expect(getByText('Tether')).toBeOnTheScreen();
expect(getByText('Dai')).toBeOnTheScreen();
expect(getByText('Wrapped Ether')).toBeOnTheScreen();
expect(getByText('ChainLink')).toBeOnTheScreen();
expect(getByText('Uniswap')).toBeOnTheScreen();
});

it('renders the view without errors', () => {
Expand Down
2 changes: 1 addition & 1 deletion app/components/UI/Money/components/MoneyPotentialEarnings/MoneyPotentialEarnings.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,7 +520,7 @@ describe('MoneyPotentialEarnings', () => {
expect(
getAllByText(strings('money.potential_earnings.no_fee')),
).toHaveLength(1);
expect(queryByText('USDT')).toBeOnTheScreen();
expect(queryByText('Tether')).toBeOnTheScreen();
});
});
});
19 changes: 17 additions & 2 deletions app/components/UI/Money/components/MoneyPotentialEarnings/PotentialEarningsTokenRow.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ describe('PotentialEarningsTokenRow', () => {
mockMoneyFormatFiat.mockClear();
});

it('renders the token symbol', () => {
it('renders the token name', () => {
const { getByText } = render(
<PotentialEarningsTokenRow
token={MOCK_USDC}
Expand All @@ -71,6 +71,21 @@ describe('PotentialEarningsTokenRow', () => {
/>,
);

expect(getByText('USD Coin')).toBeOnTheScreen();
});

it('falls back to the token symbol when name is empty', () => {
const noNameToken = makeToken({ name: '', symbol: 'USDC' });
const { getByText } = render(
<PotentialEarningsTokenRow
token={noNameToken}
hasSubsidizedFee={false}
apyDecimal={0.2}
onCardPress={jest.fn()}
onButtonPress={jest.fn()}
/>,
);

expect(getByText('USDC')).toBeOnTheScreen();
});

Expand Down Expand Up @@ -193,7 +208,7 @@ describe('PotentialEarningsTokenRow', () => {
/>,
);

fireEvent.press(getByText('USDC'));
fireEvent.press(getByText('USD Coin'));

expect(mockOnPress).toHaveBeenCalledTimes(1);
});
Expand Down
2 changes: 1 addition & 1 deletion app/components/UI/Money/components/MoneyPotentialEarnings/PotentialEarningsTokenRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ const PotentialEarningsTokenRow = ({
twClassName="gap-1"
>
<Text variant={TextVariant.BodyMd} fontWeight={FontWeight.Medium}>
{token.symbol}
{token.name || token.symbol}
</Text>
{hasSubsidizedFee && (
<Box twClassName="rounded bg-primary-muted px-1.5">
Expand Down
Loading