Skip to content

fix: MUSD-1165 Inconsistency with asset names#33140

Merged
Kureev merged 2 commits into
mainfrom
fix/musd-1165-update-earn-on-your-crypto-token-rows-to-display-asset-name
Jul 11, 2026
Merged

fix: MUSD-1165 Inconsistency with asset names#33140
Kureev merged 2 commits into
mainfrom
fix/musd-1165-update-earn-on-your-crypto-token-rows-to-display-asset-name

Conversation

@Matt561

@Matt561 Matt561 commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Description

The "Earn on your crypto" token rows on Money surfaces showed asset tickers (USDC, USDT, DAI) instead of full asset names, which was inconsistent with how the home page displays assets. Swapped the token row label to use token.name instead of token.symbol.

Changelog

CHANGELOG entry: Fixed asset names on the "Earn on your crypto" rows to display full names instead of tickers, consistent with the home page

Related issues

Fixes: MUSD-1165: Inconsistency with asset names

Manual testing steps

Feature: Earn on your crypto asset names

  Scenario: user views their eligible tokens on the Money potential earnings screen
    Given the user has eligible tokens including USDC, USDT, DAI, WETH, LINK, and UNI

    When user opens the "Earn on your crypto" / potential earnings view
    Then each token row displays the full asset name (e.g. "USD Coin", "Tether", "Dai") instead of the ticker

Screenshots/Recordings

Before

Token rows displayed asset symbols instead of names.

After

image

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Small UI label change in Money potential earnings with no auth, data, or business-logic impact beyond display text.

Overview
Earn on your crypto token rows on Money surfaces now show full asset names (e.g. USD Coin, Tether) instead of tickers, matching how assets appear on the home page.

PotentialEarningsTokenRow labels use token.name with token.symbol as fallback when the name is missing. Tests were updated for the new copy and for the empty-name fallback.

Reviewed by Cursor Bugbot for commit 24eb3ee. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Matt561 Matt561 marked this pull request as ready for review July 10, 2026 19:36
@Matt561 Matt561 requested a review from a team as a code owner July 10, 2026 19:36

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ecf9124. Configure here.

@github-actions github-actions Bot added the risk:medium AI analysis: medium risk label Jul 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeMoney
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 90%
click to see 🤖 AI reasoning details

E2E Test Selection:
The PR contains one production code change in PotentialEarningsTokenRow.tsx (Money/Card feature area): displaying token.name || token.symbol instead of just token.symbol. The remaining 3 files are unit test updates to match the new display behavior. This is a small, isolated UI change in the MetaMask Card potential earnings view. It only affects the SmokeMoney area (Card home screen, Add Funds flows). No shared infrastructure, controllers, navigation, or confirmation flows are touched. SmokeMoney is the appropriate and sufficient tag. No dependent tags are required since this change doesn't involve swap execution or wallet home entry points.

Performance Test Selection:
The change is a minor UI text display update (token name vs symbol) in the Money/Card potential earnings component. This has no impact on app performance metrics such as launch time, login, asset loading, or any other measured performance scenario.

View GitHub Actions results

@github-actions github-actions Bot added risk:low AI analysis: low risk and removed risk:medium AI analysis: medium risk labels Jul 10, 2026
@sonarqubecloud

Copy link
Copy Markdown

@Kureev Kureev added this pull request to the merge queue Jul 11, 2026
Merged via the queue into main with commit 458ad3a Jul 11, 2026
97 of 99 checks passed
@Kureev Kureev deleted the fix/musd-1165-update-earn-on-your-crypto-token-rows-to-display-asset-name branch July 11, 2026 18:17
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 11, 2026
@mm-token-exchange-service mm-token-exchange-service Bot added the release-8.4.0 Issue or pull request that will be included in release 8.4.0 label Jul 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-8.4.0 Issue or pull request that will be included in release 8.4.0 risk:low AI analysis: low risk size-S team-earn

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants