Skip to content

pass our CA cert when configuring Pulp3 Client#11190

Closed
evgeni wants to merge 1 commit into
Katello:masterfrom
evgeni:pulp-ca-cert
Closed

pass our CA cert when configuring Pulp3 Client#11190
evgeni wants to merge 1 commit into
Katello:masterfrom
evgeni:pulp-ca-cert

Conversation

@evgeni

@evgeni evgeni commented Oct 25, 2024

Copy link
Copy Markdown
Member

What are the changes introduced in this pull request?

Considerations taken when implementing this change?

What are the testing steps for this pull request?

@ekohl

ekohl commented Oct 25, 2024

Copy link
Copy Markdown
Member

This reminds me I started #8832 a long time ago and I should revisit that.

@evgeni

evgeni commented Oct 25, 2024

Copy link
Copy Markdown
Member Author

bleh, this doesn't work as it should, whyyy

@evgeni

evgeni commented Oct 25, 2024

Copy link
Copy Markdown
Member Author

bleh, this doesn't work as it should, whyyy

because @evgeni restarted foreman after changing the code, but not the dynflow worker, and the code talking to Pulp obviously runs there…

end

def self.ca_cert_filename
Setting[:ssl_ca_file]

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but… is that the right file?
it's /etc/foreman/proxy_ca.pem, which is the one we use to talk to proxies.
but here, were talking to Pulpcore via Apache, and Apache will be using the server-ca?

@ehelms halp

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so, but I still prefer #8832 which defaults to that file while still allowing to override it if needed. It also works it into the ping controller.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's /etc/foreman/proxy_ca.pem, which is the one we use to talk to proxies.
but here, were talking to Pulpcore via Apache, and Apache will be using the server-ca?

And that should be correct and fine: see https://github.com/theforeman/foreman-installer/pull/965/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R165

@evgeni

evgeni commented Oct 29, 2024

Copy link
Copy Markdown
Member Author

Fixed by #8832, thanks Ewoud!

@evgeni evgeni closed this Oct 29, 2024
@evgeni
evgeni deleted the pulp-ca-cert branch October 29, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants