Finalize Json interface, cleaning up the main branch. - #6
Open
Pamicoding wants to merge 28 commits into
Open
Conversation
Pamicoding
commented
Jul 29, 2026
Pamicoding
commented
Member
- Interface migration: Migrated from the previous Python class interface to a JSON interface, to better support users in configuring their own settings.
- Multi-config testing support: Now supports multiple configs in the same JSON, making it convenient to run several tests at once.
- Keeping main clean, removing DAS: The codebase still contains legacy DAS support code, but the current stable version focuses on supporting conventional seismometers. The DAS version involves too many specific scenarios and may not be general enough for main — hoping to develop it more thoroughly in a separate branch going forward.
- Added unit tests and a simple ruff check CI flow
- Updated demo_autoquake.ipynb and README
- Resolved issues and some bugs in the data processing pipeline handoffs
This reverts commit df9442e.
There was a problem hiding this comment.
Maybe the test folder, like pz and sac, could be include in .gitignore file ?
Member
Author
There was a problem hiding this comment.
Hey bro since I use github action to do some simple unit tests and lint check, so I intentionally keep that in the /tests (although currently it remains skip). I hope maybe we can use the sac, pz to do the test in the later version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.