Fix validation and add more tests - #585

Merged

lukaspie merged 49 commits into

fix_validation_and_add_more_tests

Mar 17, 2025

Commits on Feb 18, 2025

Fix the nx_char type for numpy to and .
RubelMozumder
committed
0f46c34

Commits on Feb 19, 2025

Still char instead of the int is being validated which is wrong.
RubelMozumder
committed
dd8beb4

Commits on Feb 20, 2025

Remove auto conversion for datatype.
RubelMozumder
committed
351f377
extends tests.
RubelMozumder
committed
00b78aa

Commits on Feb 27, 2025

resolve PR comments
RubelMozumder
committed
3ad40a0
Remove unnecessary returned value.
RubelMozumder
committed
6cf6f6d
fix np integer and float.
RubelMozumder
committed
539bdea

Commits on Feb 28, 2025

minor change.
RubelMozumder
committed
cde7a6e
check enums for documented fields, and don't return False if any issue with documented keys
rettigl
committed
4ab4b53
add enum checking for attributes
rettigl
committed
ae10916
Adds parsing code for enumeration tree generation during validation

sherjeelshabih
authored and
rettigl
committed
8f4291e
Fix typos in old test

sherjeelshabih
authored and
rettigl
committed
099b965
always check data types and enums, and check NXdata attributes separately
rettigl
committed
4da5735
fix typos
rettigl
committed
d4f4c2f
move enum checking into is_valid_data_field, and proper bool conversion
rettigl
committed
1925d5d
satisfy mypy
rettigl
committed
ecb4914

Commits on Mar 4, 2025

Commits on Mar 5, 2025

add review suggestion
rettigl
committed
31cd131
Merge pull request #573 from FAIRmat-NFDI/add_more_tests
sherjeelshabih
authored
ca1ef4f
Fixes the types and removes bytes from NX_char as that creates failures
sherjeelshabih
committed
3aabe0b
Fixes for arrays in an array
sherjeelshabih
committed
bd478e8
fix mypy error
rettigl
committed
b336ca5
ruff
rettigl
committed
e9b025e

Commits on Mar 11, 2025

Applies suggested fix

sherjeelshabih
and
rettigl
authored
8c89eef
Update src/pynxtools/dataconverter/helpers.py

sherjeelshabih
and
rettigl
authored
1c5538d
Applies fixes from suggestions
sherjeelshabih
authored
365f061
Updates
sherjeelshabih
authored
bd250cc
Ruff
sherjeelshabih
committed
84426b7
Update src/pynxtools/dataconverter/helpers.py

sherjeelshabih
and
rettigl
authored
5a63c3b
ruff
sherjeelshabih
committed
0d056b7
remove empty string
rettigl
committed
70a457c
Fixes
sherjeelshabih
committed
b6b112b

Commits on Mar 13, 2025

rename original into one of the aux copies
rettigl
committed
467194e
clean copies
rettigl
committed
65a1774
revert name of original file
rettigl
committed
a93300f
rename original targets
rettigl
committed
9023d8d
rename aux targets
rettigl
committed
36b6517
combine with renamed
rettigl
committed
ce574a8
restore original target filenames
rettigl
committed
d878bf0
fix converted tests
rettigl
committed
5bba3d3
add additional tests for base class elements
rettigl
committed
6520ffa
fix validation issues and add further tests
rettigl
committed
67cb8c1
add case and tests for undocumented units
rettigl
committed
25fe60e
Merge remote-tracking branch 'origin/master' into fix_validation_and_add_more_tests
rettigl
committed
5a8b46a
reset definitions
rettigl
committed
3a4ecd8
revert tests and reflog
rettigl
committed
74bb0da
update definitions to ref
rettigl
committed
88451d7
revert nomad example test - open enums not working yet
rettigl
committed
7de7d5a