Fix validation and add more tests - #585
Merged
Merged
Conversation
…e with documented keys
Fix for checking of undocumented keys
Add more tests
Co-authored-by: Laurenz Rettig <53396064+rettigl@users.noreply.github.com>
Co-authored-by: Laurenz Rettig <53396064+rettigl@users.noreply.github.com>
Co-authored-by: Laurenz Rettig <53396064+rettigl@users.noreply.github.com>
Collaborator
|
For some reason, in the pytest workflow, 802fc31 is checked out. This is the commit that you would usually get after you have merged this PR into master. I am quite confused, why does this commit exist at all already? In addition, it checks out FAIRmat-NFDI/nexus_definitions@3f66054. But for branch here, the definitions are supposedly at https://github.com/FAIRmat-NFDI/nexus_definitions/tree/6e3134567d715198a03499d2ff1811389b2e6462, aka the old definitions we had for some time now. I am not sure what's going on. |
Contributor
Author
|
pynxtools tests pass now, but plugin tests have more severe problems. Need to investigate that further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces #554 with properly keeping the git history. File contents are the same.