XPS reader: update to new NXmpes after refactor - #207
Merged
Conversation
2 tasks
Pull Request Test Coverage Report for Build 7531083381
💛 - Coveralls |
Pull Request Test Coverage Report for Build 7613259204
💛 - Coveralls |
…concept name included
lukaspie
marked this pull request as ready for review
January 22, 2024 06:07
domna
previously approved these changes
Jan 22, 2024
Contributor
|
Sorry, I was too quick. There seem still to be a few tests failing after re-enabling the XPSReader test |
…I/pynxtools into 206-xps-reader-nxmpes-update
domna
reviewed
Jan 22, 2024
domna
left a comment
Contributor
There was a problem hiding this comment.
There are some comments on the eln data
domna
approved these changes
Jan 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
definitionssubmodule after mpes-refactorToDo: Allow list of options in config file values, i.e. first the reader searches the metadata, then the ELN (will be new PR)