Skip to content

changes for requiredness relaxation, partial names, temperature_env o… - #338

Merged
sanbrock merged 24 commits into
fairmatfrom
multiple_optical_spec_changes2
Mar 12, 2025
Merged

changes for requiredness relaxation, partial names, temperature_env o…#338
sanbrock merged 24 commits into
fairmatfrom
multiple_optical_spec_changes2

Conversation

@RonHildebrandt

@RonHildebrandt RonHildebrandt commented Feb 25, 2025

Copy link
Copy Markdown
  • Includes relaxation of URL requirement in NXraman
  • Introducing the nameType=partial (removed from here. Reopend other PR: Name type for opt spec #333)
  • Changing environment in optical spectroscopy for the same do be directly dereived from NXsample and not from generic environment.
  • Relaxing requirements of detector type

…f SAMPLE in NXoptical_spec, make URLS recommended
@RonHildebrandt

Copy link
Copy Markdown
Author

Not sure, why ther are so many whitespace changes. did not see any of that in VSCode...

Comment thread contributed_definitions/nyaml/NXoptical_spectroscopy.yaml

@lukaspie lukaspie left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sanbrock
sanbrock merged commit 260ed3d into fairmat Mar 12, 2025
@lukaspie
lukaspie deleted the multiple_optical_spec_changes2 branch March 12, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants